Re: [PATCH v5] I2C: add CSR SiRFprimaII on-chip I2C controllers driver

[Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]

Hi Barry,

> if ACK is not received, an interrupt will be got and related register
> status can show this error. that is just a common feature in almost
> all i2c controllers? so the naming is confused. i just copied it from
> the spec.

Yes, this is common and yes, the naming is confusing :) This is why I
asked if it really does what I believed it does. All is fine, no need
for a change.

> the mail webpages and clients really fails to show the difference. i

Not all of them. gmane looks OK both in web-interface and via NNTP.

> >> >> +     siic->irq = platform_get_irq(pdev, 0);
> >> >> +     if (siic->irq < 0) {
> >> >> +             err = -EINVAL;
> >> >> +             goto out;
> >> >> +     }
> >> >
> >> > return the error code here?
> >>
> >> out lable will free resources and return error code.
> >
> > Sorry, I meant the error code you received which is in siic->irq.
> 
> ok. err = -ENXIO

err = ssic->irq?

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]