From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Robin Holt <holt-sJ/iWh9BUns@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Richard Röjfors"
<richard.rojfors-gfIc91nka+FZroRs9YW3xA@public.gmane.org>,
"Ben Dooks" <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
info-l7gf1WXxx3uGw+nKnLezzg@public.gmane.org,
"Michael Lawnick" <ml.lawnick-Mmb7MZpHnFY@public.gmane.org>,
"Rodolfo Giometti" <giometti-k2GhghHVRtY@public.gmane.org>
Subject: Re: Xilinx iic i2c bus interface GPIO support for i2c-mux in Linux.
Date: Wed, 8 Feb 2012 20:54:29 +0100 [thread overview]
Message-ID: <20120208205429.672c9092@endymion.delvare> (raw)
In-Reply-To: <20120208194615.GT14907-sJ/iWh9BUns@public.gmane.org>
Hi Robin,
On Wed, 8 Feb 2012 13:46:15 -0600, Robin Holt wrote:
> We are using a Xilinx FPGA which implements a series of i2c bus
> interfaces. We are planning on implementing a single-bit GPIO
> (XIIC_GPO_REG_OFFSET) which is included in that logic block to act
> as a MUX selector (also in the FPGA) between two separate i2c busses.
>
> This will require a GPIO driver in the linux kernel.
>
> Is it better to try and change the i2c-xiic.c code which already knows
> about the GPO register to handle that additional GPIO or should we be
> implementing the GPIO driver outside the i2c driver and then use the
> standard i2c-mux support available in newer kernels?
Both are possible. It depends if there are other GPIOs on your FPGA
which you will have to access from other drivers for other purposes. If
there are such other GPIOs then it certainly makes sense to have a
clean, separate gpio driver for your FPGA, and have all consumers bind
to it. If not, then I'd keep things simple and embed everything in
i2c-xiic.c, especially if the two i2c buses are truly separated and
there is no common trunk (i2c-mux would create 3 segments.)
--
Jean Delvare
next prev parent reply other threads:[~2012-02-08 19:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 19:46 Xilinx iic i2c bus interface GPIO support for i2c-mux in Linux Robin Holt
[not found] ` <20120208194615.GT14907-sJ/iWh9BUns@public.gmane.org>
2012-02-08 19:54 ` Jean Delvare [this message]
[not found] ` <20120208205429.672c9092-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-02-08 20:02 ` Robin Holt
[not found] ` <20120208200206.GW14907-sJ/iWh9BUns@public.gmane.org>
2012-02-08 20:47 ` Jean Delvare
2012-02-13 23:12 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120208205429.672c9092@endymion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=giometti-k2GhghHVRtY@public.gmane.org \
--cc=holt-sJ/iWh9BUns@public.gmane.org \
--cc=info-l7gf1WXxx3uGw+nKnLezzg@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ml.lawnick-Mmb7MZpHnFY@public.gmane.org \
--cc=richard.rojfors-gfIc91nka+FZroRs9YW3xA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).