From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Huisung Kang <hs1218.kang@samsung.com>
Cc: linux-i2c@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
ben-linux@fluff.org, kgene.kim@samsung.com
Subject: Re: [PATCH] i2c-s3c2410: move resume state flag to end of resume
Date: Sun, 12 Feb 2012 13:12:31 +0000 [thread overview]
Message-ID: <20120212131230.GB3395@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <018401cce86c$5df94130$19ebc390$@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 398 bytes --]
On Sat, Feb 11, 2012 at 12:22:21PM +0900, Huisung Kang wrote:
> From: Kisoo Yu <ksoo.yu@samsung.com>
> need to set flag after finishing its work
> - i2c->suspended = 0;
> clk_enable(i2c->clk);
> s3c24xx_i2c_init(i2c);
> clk_disable(i2c->clk);
> + i2c->suspended = 0;
Why is this needed - given that there's no locking involved anywhere
here does this mean that we've got a race somewhere?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-12 13:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-11 3:22 [PATCH] i2c-s3c2410: move resume state flag to end of resume Huisung Kang
2012-02-12 13:12 ` Mark Brown [this message]
[not found] ` <20120212131230.GB3395-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-02-13 22:54 ` Ben Dooks
2012-02-13 22:53 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120212131230.GB3395@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=ben-linux@fluff.org \
--cc=hs1218.kang@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).