From: Ben Dooks <ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
To: Mark Brown
<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
Cc: Huisung Kang
<hs1218.kang-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org,
kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org
Subject: Re: [PATCH] i2c-s3c2410: move resume state flag to end of resume
Date: Mon, 13 Feb 2012 22:54:39 +0000 [thread overview]
Message-ID: <20120213225439.GB2999@freya.fluff.org> (raw)
In-Reply-To: <20120212131230.GB3395-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
On Sun, Feb 12, 2012 at 01:12:31PM +0000, Mark Brown wrote:
> On Sat, Feb 11, 2012 at 12:22:21PM +0900, Huisung Kang wrote:
> > From: Kisoo Yu <ksoo.yu-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>
> > need to set flag after finishing its work
>
> > - i2c->suspended = 0;
> > clk_enable(i2c->clk);
> > s3c24xx_i2c_init(i2c);
> > clk_disable(i2c->clk);
> > + i2c->suspended = 0;
>
> Why is this needed - given that there's no locking involved anywhere
> here does this mean that we've got a race somewhere?
It is in the wrong order, the lack of locking is a bit of a problem
but then again so is the whole suspend/resume framework at the
moment. I'm inclined to apply this to the fixes branch.
--
Ben
next prev parent reply other threads:[~2012-02-13 22:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-11 3:22 [PATCH] i2c-s3c2410: move resume state flag to end of resume Huisung Kang
2012-02-12 13:12 ` Mark Brown
[not found] ` <20120212131230.GB3395-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-02-13 22:54 ` Ben Dooks [this message]
2012-02-13 22:53 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120213225439.GB2999@freya.fluff.org \
--to=ben-i2c-elnmno+kys3ytjvyw6ydsg@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=hs1218.kang-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).