From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Dooks Subject: Re: [PATCH 2/2] i2c: tegra: Remove unnecessary write to INT_STATUS Date: Mon, 13 Feb 2012 23:24:28 +0000 Message-ID: <20120213232427.GG2999@freya.fluff.org> References: <1328314217-16632-1-git-send-email-swarren@nvidia.com> <1328314217-16632-2-git-send-email-swarren@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1328314217-16632-2-git-send-email-swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Warren Cc: Ben Dooks , Wolfram Sang , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alok Chauhan List-Id: linux-i2c@vger.kernel.org On Fri, Feb 03, 2012 at 05:10:17PM -0700, Stephen Warren wrote: > From: Alok Chauhan > > The write is not necessary and may cause the I2C controller to misbehave. > With this fix, I2C on Tegra30 works (at least, running i2cdump repeatedly > on the WM8903 on Cardhu's I2C5/DVC bus). > > Originally by Alok Chauhan , but S-o-b missing in our > internal repo. > > [swarren: Reworded commit description] > Signed-off-by: Stephen Warren I'll apply this as it seems to have gone by without major comment. > --- > drivers/i2c/busses/i2c-tegra.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c > index a546ede..edac27b 100644 > --- a/drivers/i2c/busses/i2c-tegra.c > +++ b/drivers/i2c/busses/i2c-tegra.c > @@ -456,7 +456,6 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev, > int ret; > > tegra_i2c_flush_fifos(i2c_dev); > - i2c_writel(i2c_dev, 0xFF, I2C_INT_STATUS); > > if (msg->len == 0) > return -EINVAL; > -- > 1.7.0.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-i2c" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html