From: Russell King - ARM Linux <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
To: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: Jean-Christophe PLAGNIOL-VILLARD
<plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>,
Karol Lewandowski
<k.lewandowsk-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Grant Likely
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 1/4 v2] i2c/gpio: add DT support
Date: Mon, 20 Feb 2012 13:51:06 +0000 [thread overview]
Message-ID: <20120220135106.GA26840@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20120220143557.02787bad-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
On Mon, Feb 20, 2012 at 02:35:57PM +0100, Jean Delvare wrote:
> On Mon, 20 Feb 2012 12:50:54 +0000, Russell King - ARM Linux wrote:
> > What is linux specific is specifying the _delay_ rather than specifying
> > the bus frequency. So as soon as you're trying to justify not adding
> > the units because they may be linux specific, you've already lost that
> > argument by using a delay rather than a bus frequency. You can't have
> > it both ways.
>
> While I am not much into DT and did not follow this thread too
> carefully... I seem to understand that the dispute is mainly on
> frequency vs. udelay specification for the bus speed, Jean-Christophe
> arguing that hardware-specific delays are added when changing e.g. a
> GPIO pin output value and thus the frequency can't be guaranteed. Do I
> get this right?
This sub-thread is more about the units of the properties rather
than the properties themselves.
What's being proposed is to have two properties, one named 'udelay'
which takes microseconds, and one named 'timeout' which takes
milliseconds.
I'm saying that's a completely absurd proposal, as the proposal is
for two opaque numeric properties with different units. At least
make the units the same, or as Karol said, incorporate the units
into the property names.
At least we can then create new properties in the future of we need
to change the units, rather than thinking up a different name for
'timeout'.
next prev parent reply other threads:[~2012-02-20 13:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 2:25 [PATCH 1/4 v2] i2c/gpio: add DT support Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <1328754308-7365-1-git-send-email-plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
2012-02-13 17:17 ` Karol Lewandowski
2012-02-20 9:58 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <20120220095813.GB11307-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-02-20 10:08 ` Russell King - ARM Linux
[not found] ` <20120220100843.GE22562-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-02-20 10:22 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <20120220102231.GC11307-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-02-20 12:50 ` Russell King - ARM Linux
[not found] ` <20120220125054.GF22562-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-02-20 13:35 ` Jean Delvare
[not found] ` <20120220143557.02787bad-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-02-20 13:51 ` Russell King - ARM Linux [this message]
[not found] ` <20120220135106.GA26840-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-02-20 14:51 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <20120220145137.GG11307-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-02-20 15:03 ` Russell King - ARM Linux
2012-02-20 13:37 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <20120220133725.GD11307-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-02-20 13:46 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <20120220134634.GE11307-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-02-20 13:58 ` Russell King - ARM Linux
[not found] ` <20120220135807.GB26840-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-02-20 14:46 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <20120220144635.GF11307-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-02-20 15:00 ` Russell King - ARM Linux
[not found] ` <20120220150040.GC26840-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-02-20 15:08 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <20120220150810.GH11307-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-02-20 15:27 ` Russell King - ARM Linux
[not found] ` <20120220152748.GF26840-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-02-20 15:30 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <20120220153006.GK11307-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-02-20 15:46 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <20120220154613.GL11307-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-02-20 16:08 ` Russell King - ARM Linux
[not found] ` <20120220160855.GG26840-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-02-20 16:09 ` Jean-Christophe PLAGNIOL-VILLARD
2012-02-13 23:09 ` Ben Dooks
2012-02-14 4:06 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120220135106.GA26840@n2100.arm.linux.org.uk \
--to=linux-lfz/pmaqli7xmaaqvzeohq@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=k.lewandowsk-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).