From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH V1] i2c: gpio: Use open drain support from gpio driver Date: Wed, 7 Mar 2012 18:39:22 +0100 Message-ID: <20120307173922.GB1130@pengutronix.de> References: <1331127494-6913-1-git-send-email-ldewangan@nvidia.com> <20120307173157.GT3107@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oC1+HKm2/end4ao3" Return-path: Content-Disposition: inline In-Reply-To: <20120307173157.GT3107-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: Laxman Dewangan , khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org, ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org, linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org --oC1+HKm2/end4ao3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 07, 2012 at 05:31:57PM +0000, Mark Brown wrote: > On Wed, Mar 07, 2012 at 07:08:14PM +0530, Laxman Dewangan wrote: > > The gpio core driver (gpio library) supports the open > > drain pin handling. Therefore, it is not require it > > to handle in the i2c-gpio driver, just require > > to pass the OPEN_DRAIN type flag when requesting the gpio. >=20 > Reviwed-by: Mark Brown Typo ;) >=20 > but note that this is a new gpiolib feature in -next and will need to > either be applied via Grant's tree or wait until after the merge window. I'll pick it for v3.5 later. Thanks for the review! Wolfram --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --oC1+HKm2/end4ao3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAk9XnUoACgkQD27XaX1/VRu0yQCgwyR3SZ5kEPkYeE0p53PHaa+I Om8AnRgak1mDjdFhqAIaouyVEVMyc39V =Zh2i -----END PGP SIGNATURE----- --oC1+HKm2/end4ao3--