From: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
To: Marc Reilly <marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org>
Cc: sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
oskar-fYPSZ7JpQqsAvxtiuMwx3w@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3 4/6] mfd: mc13xxx-core: use regmap for register access
Date: Thu, 15 Mar 2012 17:43:44 +0000 [thread overview]
Message-ID: <20120315174343.GQ3138@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1331757790-10583-5-git-send-email-marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 677 bytes --]
On Thu, Mar 15, 2012 at 07:43:08AM +1100, Marc Reilly wrote:
> This change converts the mc13xxx core to use regmap rather than direct
> spi r/w.
> The spidev member of mc13xxx struct becomes redundant and is removed.
> Extra debugging aids are added to mc13xxx_reg_rmw.
> Mutex init is moved to before regmap init.
Reviwed-by: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
For rmw please push the trace down into regmap as a new tracepoint if
you find it useful; one of the wins from regmap is intended to be the
trace and diagnostic infrastructure you get for free with it. At the
minute only the underlying reads and writes have trace.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-03-15 17:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 20:43 mc13xxx: add I2C support (now with regmap), V3 Marc Reilly
[not found] ` <1331757790-10583-1-git-send-email-marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org>
2012-03-14 20:43 ` [PATCH v3 1/6] regmap: add support for 7_25 format Marc Reilly
[not found] ` <1331757790-10583-2-git-send-email-marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org>
2012-03-15 10:44 ` Mark Brown
[not found] ` <20120315104443.GC3138-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-03-15 22:51 ` Marc Reilly
2012-03-14 20:43 ` [PATCH v3 2/6] regmap: Add support for device with 24 data bits Marc Reilly
[not found] ` <1331757790-10583-3-git-send-email-marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org>
2012-03-15 10:46 ` Mark Brown
[not found] ` <20120315104617.GD3138-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-03-15 20:55 ` Marc Reilly
2012-03-14 20:43 ` [PATCH v3 3/6] mfd: mc13xxx-core: Prepare for separate spi and i2c backends Marc Reilly
2012-03-14 20:43 ` [PATCH v3 4/6] mfd: mc13xxx-core: use regmap for register access Marc Reilly
[not found] ` <1331757790-10583-5-git-send-email-marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org>
2012-03-15 17:43 ` Mark Brown [this message]
2012-03-14 20:43 ` [PATCH v3 5/6] mfd: mc13xxx-core: Move spi specific code into separate module Marc Reilly
2012-03-14 20:43 ` [PATCH v3 6/6] mfd: mc13xxx: Add i2c driver Marc Reilly
[not found] ` <1331757790-10583-7-git-send-email-marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org>
2012-03-14 22:15 ` Fabio Estevam
[not found] ` <CAOMZO5BVObpszMd4_dDr3NHw9-oXh9wY_T48UA2vMWozdUyukw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-15 20:57 ` Marc Reilly
2012-03-15 13:40 ` Shubhrajyoti Datta
[not found] ` <CAM=Q2cssNF2TSWHjcbG4wsABBXhquYoKq_scC6bDcq8kdoosyQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-15 20:59 ` Marc Reilly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120315174343.GQ3138@opensource.wolfsonmicro.com \
--to=broonie-yzvpicuk2aatku/dhu1wvuem+bqzidxxqq4iyu8u01e@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org \
--cc=oskar-fYPSZ7JpQqsAvxtiuMwx3w@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).