From: Grant Likely <grant.likely@secretlab.ca>
To: ben-linux@fluff.org
Cc: thomas.abraham@linaro.org, m.szyprowski@samsung.com,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
linux-samsung-soc@vger.kernel.org, t.stanislaws@samsung.com,
Karol Lewandowski <k.lewandowsk@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH 1/3] i2c-s3c2410: Drop unused define
Date: Sun, 18 Mar 2012 20:49:37 +0000 [thread overview]
Message-ID: <20120318204937.0F6AB3E07BF@localhost> (raw)
In-Reply-To: <1331657679-31302-2-git-send-email-k.lewandowsk@samsung.com>
On Tue, 13 Mar 2012 17:54:37 +0100, Karol Lewandowski <k.lewandowsk@samsung.com> wrote:
> Use standard of_match_ptr() to avoid defining variable unused
> in non device tree builds.
>
> Signed-off-by: Karol Lewandowski <k.lewandowsk@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
> ---
> drivers/i2c/busses/i2c-s3c2410.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
> index 737f721..85e3664 100644
> --- a/drivers/i2c/busses/i2c-s3c2410.c
> +++ b/drivers/i2c/busses/i2c-s3c2410.c
> @@ -1128,8 +1128,6 @@ static const struct of_device_id s3c24xx_i2c_match[] = {
> {},
> };
> MODULE_DEVICE_TABLE(of, s3c24xx_i2c_match);
> -#else
> -#define s3c24xx_i2c_match NULL
> #endif
>
> static struct platform_driver s3c24xx_i2c_driver = {
> @@ -1140,7 +1138,7 @@ static struct platform_driver s3c24xx_i2c_driver = {
> .owner = THIS_MODULE,
> .name = "s3c-i2c",
> .pm = S3C24XX_DEV_PM_OPS,
> - .of_match_table = s3c24xx_i2c_match,
> + .of_match_table = of_match_ptr(s3c24xx_i2c_match),
> },
> };
>
> --
> 1.7.9
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies,Ltd.
next prev parent reply other threads:[~2012-03-18 20:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 16:54 [PATCH 0/3 v2] Updates for exynos4210 and DT-based systems Karol Lewandowski
2012-03-13 16:54 ` [PATCH 1/3] i2c-s3c2410: Drop unused define Karol Lewandowski
2012-03-18 20:49 ` Grant Likely [this message]
2012-03-13 16:54 ` [PATCH 2/3] i2c-s3c2410: Rework device type handling Karol Lewandowski
[not found] ` <1331657679-31302-3-git-send-email-k.lewandowsk-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-03-14 17:29 ` Mark Brown
[not found] ` <20120314172915.GB13393-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2012-03-15 10:04 ` Karol Lewandowski
[not found] ` <4F61BEC8.4030008-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-03-15 12:56 ` Mark Brown
[not found] ` <20120315125630.GK3138-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-03-15 16:54 ` Karol Lewandowski
2012-03-19 19:55 ` Mark Brown
2012-03-21 10:33 ` Karol Lewandowski
[not found] ` <4F69AE96.6060901-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-03-21 11:50 ` Mark Brown
2012-03-21 11:54 ` Karol Lewandowski
[not found] ` <1331657679-31302-1-git-send-email-k.lewandowsk-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-03-13 16:54 ` [PATCH 3/3] i2c-s3c2410: Add HDMIPHY quirk for S3C2440 Karol Lewandowski
[not found] ` <1331657679-31302-4-git-send-email-k.lewandowsk-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-03-13 17:27 ` Tomasz Stanislawski
[not found] ` <4F5F838A.6030908-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-03-13 18:00 ` Karol Lewandowski
2012-03-13 18:13 ` [PATCH] " Karol Lewandowski
2012-03-14 1:49 ` [PATCH 0/3 v2] Updates for exynos4210 and DT-based systems Kyungmin Park
-- strict thread matches above, loose matches on Subject: below --
2012-03-21 19:11 [PATCH v3 0/3] i2c-s3c2410: " Karol Lewandowski
[not found] ` <1332357113-2973-1-git-send-email-k.lewandowsk-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-03-21 19:11 ` [PATCH 1/3] i2c-s3c2410: Drop unused define Karol Lewandowski
[not found] ` <1332357113-2973-2-git-send-email-k.lewandowsk-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-04-18 10:56 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120318204937.0F6AB3E07BF@localhost \
--to=grant.likely@secretlab.ca \
--cc=ben-linux@fluff.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=k.lewandowsk@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=t.stanislaws@samsung.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).