From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Karol Lewandowski <k.lewandowsk@samsung.com>
Cc: ben-linux@fluff.org, thomas.abraham@linaro.org,
m.szyprowski@samsung.com, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-samsung-soc@vger.kernel.org, t.stanislaws@samsung.com,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH 2/3] i2c-s3c2410: Rework device type handling
Date: Mon, 19 Mar 2012 19:55:41 +0000 [thread overview]
Message-ID: <20120319195540.GH12384@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4F621EC9.6020106@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 567 bytes --]
On Thu, Mar 15, 2012 at 05:54:33PM +0100, Karol Lewandowski wrote:
> If you consider code to be inherently less readable because of this
> approach I'll rework it. If it's not a such big deal for you I would
> prefer to keep it as is.
The thing that was causing me to think the code was funny was mainly the
fact that we're now combining both quirk based selection and chip type
based selection into the same bitmask. If the chip types were quirks
it'd probably not have looked odd, and that might just be a case of
renaming them - I can't remember what they do.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-03-19 19:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 16:54 [PATCH 0/3 v2] Updates for exynos4210 and DT-based systems Karol Lewandowski
2012-03-13 16:54 ` [PATCH 1/3] i2c-s3c2410: Drop unused define Karol Lewandowski
2012-03-18 20:49 ` Grant Likely
2012-03-13 16:54 ` [PATCH 2/3] i2c-s3c2410: Rework device type handling Karol Lewandowski
[not found] ` <1331657679-31302-3-git-send-email-k.lewandowsk-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-03-14 17:29 ` Mark Brown
[not found] ` <20120314172915.GB13393-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2012-03-15 10:04 ` Karol Lewandowski
[not found] ` <4F61BEC8.4030008-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-03-15 12:56 ` Mark Brown
[not found] ` <20120315125630.GK3138-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-03-15 16:54 ` Karol Lewandowski
2012-03-19 19:55 ` Mark Brown [this message]
2012-03-21 10:33 ` Karol Lewandowski
[not found] ` <4F69AE96.6060901-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-03-21 11:50 ` Mark Brown
2012-03-21 11:54 ` Karol Lewandowski
[not found] ` <1331657679-31302-1-git-send-email-k.lewandowsk-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-03-13 16:54 ` [PATCH 3/3] i2c-s3c2410: Add HDMIPHY quirk for S3C2440 Karol Lewandowski
[not found] ` <1331657679-31302-4-git-send-email-k.lewandowsk-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-03-13 17:27 ` Tomasz Stanislawski
[not found] ` <4F5F838A.6030908-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-03-13 18:00 ` Karol Lewandowski
2012-03-13 18:13 ` [PATCH] " Karol Lewandowski
2012-03-14 1:49 ` [PATCH 0/3 v2] Updates for exynos4210 and DT-based systems Kyungmin Park
-- strict thread matches above, loose matches on Subject: below --
2012-03-21 19:11 [PATCH v3 0/3] i2c-s3c2410: " Karol Lewandowski
2012-03-21 19:11 ` [PATCH 2/3] i2c-s3c2410: Rework device type handling Karol Lewandowski
[not found] ` <1332357113-2973-3-git-send-email-k.lewandowsk-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-03-21 20:30 ` Mark Brown
2012-04-17 17:31 ` Wolfram Sang
[not found] ` <20120417173136.GB22406-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-04-18 11:55 ` Karol Lewandowski
2012-04-18 13:39 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120319195540.GH12384@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=ben-linux@fluff.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=k.lewandowsk@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=t.stanislaws@samsung.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).