Re: [PATCH] i2c-designware: add optional regulator support

[Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 948 bytes --]

On Tue, Mar 20, 2012 at 10:46:19AM +0200, Mika Westerberg wrote:

> We already have the panel driver to manage its regulator and it works as
> should. The problem is that when we blank the display and switch off the
> panel power, it drives the whole I2C bus to low (due to HW bug in the
> panel). This effectively prevents any other driver to talk to their device
> on the same bus :-/

> This is the reason we shared the same panel regulator with I2C controller -
> power is only cut off when both drivers do regulator_disable().

Right, but the more normal thing here would be to add support to the
other client drivers rather than the controller (though there is no harm
at all in adding support to the controller, it's just a little odd
rather than wrong).  Like I say as far as the controller is concerned
you can generally turn the buffer voltage off whenever you're not
actually doing an I2C transaction which probably isn't what you want.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]