From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Linux I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 0/2] i2c-tools: Clean up <linux/i2c-dev.h>
Date: Wed, 21 Mar 2012 10:11:11 +0100 [thread overview]
Message-ID: <20120321101111.3e9202fc@endymion.delvare> (raw)
In-Reply-To: <20120315165344.5f8e060f-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
On Thu, 15 Mar 2012 16:53:44 +0100, Jean Delvare wrote:
> For years now, project i2c-tools has been carrying a modified copy of
> <linux/i2c-dev.h> for use by user-space applications
> accessing /dev/i2c-* device nodes. The modified copy includes parts of
> <linux/i2c.h> as well as i2c_smbus_*() inline functions mimicking their
> kernel counterparts.
>
> Why it was done that way, I'm not sure. Maybe to make things easier for
> application authors, or maybe just because nobody ever cared to clean
> it all up. But what I'm sure of is that the current situation is ugly
> and should be cleaned up. Kernel interfaces should be described by
> kernel header files, not random user-space tool projects.
>
> So I have a plan to get rid of <linux/i2c-dev.h> in i2c-tools. This is
> the first step of a more ambitious plan to move the inline
> i2c_smbus_*() functions to a proper library - they are too large to be
> inline functions and recent versions of gcc complain about that.
I have added a page to the wiki, describing the problem and solution:
http://www.lm-sensors.org/wiki/I2CTools_4_Plan
--
Jean Delvare
prev parent reply other threads:[~2012-03-21 9:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 15:53 [PATCH 0/2] i2c-tools: Clean up <linux/i2c-dev.h> Jean Delvare
[not found] ` <20120315165344.5f8e060f-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-03-15 15:59 ` [PATCH 1/2] " Jean Delvare
2012-03-15 16:00 ` [PATCH 2/2] Split i2c-dev.h into parts Jean Delvare
2012-03-21 9:11 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120321101111.3e9202fc@endymion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).