From: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
To: Marc Reilly <marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org>
Cc: sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
oskar-fYPSZ7JpQqsAvxtiuMwx3w@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
alexg-uRCCPK1wpQlR0G4FFNCX/g@public.gmane.org
Subject: Re: [PATCH v5 2/4] mfd: mc13xxx-core: use regmap for register access
Date: Mon, 2 Apr 2012 17:00:36 +0100 [thread overview]
Message-ID: <20120402160036.GA29808@sirena.org.uk> (raw)
In-Reply-To: <1333262499-25871-3-git-send-email-marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org>
On Sun, Apr 01, 2012 at 04:41:37PM +1000, Marc Reilly wrote:
> This change converts the mc13xxx core to use regmap rather than direct
> spi r/w.
> The spidev member of mc13xxx struct becomes redundant and is removed.
> Extra debugging aids are added to mc13xxx_reg_rmw.
To repeat what I've said on previous versions please push this down into
regmap. There's already extensive diagnostic features there, let's not
have people open coding things that are missing.
next prev parent reply other threads:[~2012-04-02 16:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-01 6:41 mc13xxx: add I2C support, V5 Marc Reilly
[not found] ` <1333262499-25871-1-git-send-email-marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org>
2012-04-01 6:41 ` [PATCH v5 1/4] mfd: mc13xxx-core: Prepare for separate spi and i2c backends Marc Reilly
2012-04-01 6:41 ` [PATCH v5 2/4] mfd: mc13xxx-core: use regmap for register access Marc Reilly
[not found] ` <1333262499-25871-3-git-send-email-marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org>
2012-04-02 16:00 ` Mark Brown [this message]
2012-04-01 6:41 ` [PATCH v5 3/4] mfd: mc13xxx-core: Move spi specific code into separate module Marc Reilly
2012-04-01 6:41 ` [PATCH v5 4/4] mfd: mc13xxx: Add i2c driver Marc Reilly
2012-04-01 9:21 ` mc13xxx: add I2C support, V5 Uwe Kleine-König
[not found] ` <20120401092125.GX15647-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-04-01 9:39 ` Marc Reilly
[not found] ` <201204011939.49665.marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org>
2012-04-02 6:40 ` Uwe Kleine-König
2012-04-16 23:21 ` Marc Reilly
[not found] ` <201204170921.42027.marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org>
2012-05-01 10:39 ` Samuel Ortiz
2012-05-01 22:55 ` Marc Reilly
2012-04-01 11:12 ` Alex Gershgorin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120402160036.GA29808@sirena.org.uk \
--to=broonie-yzvpicuk2aatku/dhu1wvuem+bqzidxxqq4iyu8u01e@public.gmane.org \
--cc=alexg-uRCCPK1wpQlR0G4FFNCX/g@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org \
--cc=oskar-fYPSZ7JpQqsAvxtiuMwx3w@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).