Re: [PATCHv7 01/18] I2C: OMAP: make omap_i2c_unidle/idle functions depend on CONFIG_PM_RUNTIME

Felipe Balbi
2012-04-11T12:00:43Z

[-- Attachment #1: Type: text/plain, Size: 1303 bytes --]

On Wed, Apr 11, 2012 at 05:29:07PM +0530, Shubhrajyoti Datta wrote:
> Hi Felipe,
>
> On Wed, Apr 11, 2012 at 5:02 PM, Felipe Balbi <balbi@ti.com> wrote:
> > On Wed, Apr 11, 2012 at 04:42:39PM +0530, Shubhrajyoti D wrote:
> >> The functions omap_i2c_unidle/idle are called from omap_i2c_runtime_resume
> >> and omap_i2c_runtime_suspend which is compiled for CONFIG_PM_RUNTIME.
> >> This patch removes the omap_i2c_unidle/idle functions and folds them
> >> into the runtime callbacks.
> >>
> >> This fixes the below warn when CONFIG_PM_RUNTIME is not defined
> >>
> >>  CC      arch/arm/mach-omap2/board-ti8168evm.o
> >> drivers/i2c/busses/i2c-omap.c:272: warning: 'omap_i2c_unidle' defined but not used
> >> drivers/i2c/busses/i2c-omap.c:293: warning: 'omap_i2c_idle' defined but not used
> >>   CC      net/ipv4/ip_forward.o
> >>
> >> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
> >
> > how about just moving them into the #ifdef ? /me thinks it's easier to
> > read with the function. Matter of taste though, it's not that much code.
>
> Kevin preferred folding into the runtime functions.
>
> http://www.spinics.net/lists/linux-omap/msg62764.html
>
> Don't feel strongly though.

ok, I stand corrected ;-) No need to change your patch again ;-)

--
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]