From: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Zhao Chenhui <chenhui.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Li Yang <leoli-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Subject: Re: [PATCH] i2c-mpc: avoid I2C abnormal after resuming from deep sleep
Date: Tue, 17 Apr 2012 16:21:05 +0200 [thread overview]
Message-ID: <20120417142105.GA21802@pengutronix.de> (raw)
In-Reply-To: <20120229183436.GA30545-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1421 bytes --]
On Wed, Feb 29, 2012 at 07:45:23PM +0100, Wolfram Sang wrote:
> Hi,
>
> On Wed, Feb 29, 2012 at 06:39:21PM +0800, Zhao Chenhui wrote:
> > When entering deep sleep, the value in the registers I2CFDR and
> > I2CDFSRR are lost. This causes I2C access to fail after resuming.
> >
> > Add suspend/resume routines to save/restore the registers
> > I2CFDR and I2CDFSRR.
> >
> > Signed-off-by: Zhao Chenhui <chenhui.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > Signed-off-by: Li Yang <leoli-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > ---
> > drivers/i2c/busses/i2c-mpc.c | 34 +++++++++++++++++++++++++++++++++-
> > 1 files changed, 33 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
> > index a8ebb84..f95a647 100644
> > --- a/drivers/i2c/busses/i2c-mpc.c
> > +++ b/drivers/i2c/busses/i2c-mpc.c
> > @@ -1,7 +1,9 @@
> > /*
> > * (C) Copyright 2003-2004
> > * Humboldt Solutions Ltd, adrian-nKrwMtk+6WksDtB2XHyCLA@public.gmane.org
> > -
> > + *
> > + * Copyright 2012 Freescale Semiconductor, Inc.
> > + *
>
> I'd think the change is too trivial to claim copyright on the file.
Do you want to resend with the comments addressed?
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-04-17 14:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 10:39 [PATCH] i2c-mpc: avoid I2C abnormal after resuming from deep sleep Zhao Chenhui
[not found] ` <1330511961-22498-1-git-send-email-chenhui.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-02-29 13:02 ` Shubhrajyoti Datta
[not found] ` <CAM=Q2ctLm8FKgTek6u9H0jzWJv1bbBUnvDHZfEA=p2ReK8ybUQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-02-29 18:08 ` Tabi Timur-B04825
2012-02-29 18:45 ` Wolfram Sang
[not found] ` <20120229183436.GA30545-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-03-01 11:27 ` Ben Dooks
2012-04-17 14:21 ` Wolfram Sang [this message]
[not found] ` <20120417142105.GA21802-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-04-18 10:20 ` Li Yang-R58472
[not found] ` <94F013E7935FF44C83EBE7784D62AD3F092D1DC7-RL0Hj/+nBVC81RJBUSuqCa4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2012-04-18 10:33 ` Wolfram Sang
[not found] ` <20120418103334.GD2232-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-04-18 14:44 ` Li Yang
[not found] ` <CADRPPNQRLyZK-zjeLUYCZtLe+8HhFzFALCMyPeaCGX+buaf+ug-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-18 21:49 ` Tabi Timur-B04825
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120417142105.GA21802@pengutronix.de \
--to=w.sang-bicnvbalz9megne8c9+irq@public.gmane.org \
--cc=chenhui.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=leoli-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).