From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH] i2c-mpc: avoid I2C abnormal after resuming from deep sleep Date: Tue, 17 Apr 2012 16:21:05 +0200 Message-ID: <20120417142105.GA21802@pengutronix.de> References: <1330511961-22498-1-git-send-email-chenhui.zhao@freescale.com> <20120229183436.GA30545@pengutronix.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cNdxnHkX5QqsyA0e" Return-path: Content-Disposition: inline In-Reply-To: <20120229183436.GA30545-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Zhao Chenhui Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Li Yang List-Id: linux-i2c@vger.kernel.org --cNdxnHkX5QqsyA0e Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 29, 2012 at 07:45:23PM +0100, Wolfram Sang wrote: > Hi, >=20 > On Wed, Feb 29, 2012 at 06:39:21PM +0800, Zhao Chenhui wrote: > > When entering deep sleep, the value in the registers I2CFDR and > > I2CDFSRR are lost. This causes I2C access to fail after resuming. > >=20 > > Add suspend/resume routines to save/restore the registers > > I2CFDR and I2CDFSRR. > >=20 > > Signed-off-by: Zhao Chenhui > > Signed-off-by: Li Yang > > --- > > drivers/i2c/busses/i2c-mpc.c | 34 +++++++++++++++++++++++++++++++++- > > 1 files changed, 33 insertions(+), 1 deletions(-) > >=20 > > diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c > > index a8ebb84..f95a647 100644 > > --- a/drivers/i2c/busses/i2c-mpc.c > > +++ b/drivers/i2c/busses/i2c-mpc.c > > @@ -1,7 +1,9 @@ > > /* > > * (C) Copyright 2003-2004 > > * Humboldt Solutions Ltd, adrian-nKrwMtk+6WksDtB2XHyCLA@public.gmane.org > > - > > + * > > + * Copyright 2012 Freescale Semiconductor, Inc. > > + * >=20 > I'd think the change is too trivial to claim copyright on the file. Do you want to resend with the comments addressed? Regards, Wolfram --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --cNdxnHkX5QqsyA0e Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAk+NfFEACgkQD27XaX1/VRsRyQCePPnnlynynpq5hVQMeZDBMIWu crsAnA4Xgpuf089oXkaxypETfwVnrNg9 =TAH2 -----END PGP SIGNATURE----- --cNdxnHkX5QqsyA0e--