From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH v2] i2c: tegra: Add delay before reset the controller Date: Wed, 18 Apr 2012 16:27:58 +0200 Message-ID: <20120418142758.GE19220@pengutronix.de> References: <1333345982-16595-1-git-send-email-alokc@nvidia.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="imjhCm/Pyz7Rq5F2" Return-path: Content-Disposition: inline In-Reply-To: <1333345982-16595-1-git-send-email-alokc-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alok Chauhan Cc: swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org, khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org, ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org, bones-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org, omaplinuxkernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org, ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org --imjhCm/Pyz7Rq5F2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 02, 2012 at 11:23:02AM +0530, Alok Chauhan wrote: > NACK interrupt generated before I2C controller generates > the STOP condition on bus. In Software, because of this > reset of controller is happening before I2C controller could > complete STOP condition. So wait for some time before resetting > the controller so that STOP condition has delivered properly on bus. >=20 > Added delay of 2 clock period before reset the > controller in case of NACK error. >=20 > Signed-off-by: Alok Chauhan Applied with Stephen's ACK and slightly reworded comment and commit msg. Wondering a bit that you want it for 3.5, not for 3.4. Looks like a bugfix to me. --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --imjhCm/Pyz7Rq5F2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAk+Oz24ACgkQD27XaX1/VRsa7QCggv2aNwPXDAt16LauuUs/fLwY 6okAoI7x3/3McmF0Y4fUHzEUDh1SG86r =1vge -----END PGP SIGNATURE----- --imjhCm/Pyz7Rq5F2--