From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH v3 2/2] i2c/of: Automatically populate i2c mux busses from device tree data. Date: Sun, 22 Apr 2012 18:20:08 +0200 Message-ID: <20120422162008.GA4201@pengutronix.de> References: <1334265263-13549-1-git-send-email-ddaney.cavm@gmail.com> <1334265263-13549-3-git-send-email-ddaney.cavm@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BOKacYhQ+x31HxR3" Return-path: Content-Disposition: inline In-Reply-To: <1334265263-13549-3-git-send-email-ddaney.cavm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: David Daney Cc: Grant Likely , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, "Jean Delvare (PC drivers core)" , "Ben Dooks (embedded platforms)" , Peter Korsgaard , Guenter Roeck , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Daney , Lars-Peter Clausen List-Id: linux-i2c@vger.kernel.org --BOKacYhQ+x31HxR3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 12, 2012 at 02:14:23PM -0700, David Daney wrote: > From: David Daney >=20 > For 'normal' i2c bus drivers, we can call of_i2c_register_devices() > and have the device tree framework automatically populate the bus with > the devices specified in the device tree. >=20 > This patch adds a common code to the i2c mux framework to have the mux > sub-busses be populated by the of_i2c_register_devices() too. If the > mux device has an of_node, we populate the sub-bus' of_node so that > the subsequent call to of_i2c_register_devices() will find the > corresponding devices. >=20 > It seemed better to put this logic in i2c_add_mux_adapter() rather > than the individual mux drivers, as they will all probably want to do > the same thing. Both patches looking mostly good, two things here: > + /* > + * Try to get populate the mux adapter's of_node, expands to "get populate"? I'd think you mean "populate" only, but am not sure enough to fix it myself. > + * nothing if !CONFIG_OF. > + */ > + if (mux_dev->of_node) { > + struct device_node *child; > + u32 reg; > + int ret; We have a "ret" already in this function. Regards, Wolfram --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --BOKacYhQ+x31HxR3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAk+UL7gACgkQD27XaX1/VRvdWgCgrlnDJ86GWtEaT3obbXaiJfuW q/YAoIzUvdOyNTDegA/3UfckWimXYdZv =nwnH -----END PGP SIGNATURE----- --BOKacYhQ+x31HxR3--