* [PATCH V3 03/12] i2c/i2c-pxa: Remove conditional compilation of clk code [not found] <cover.1335266056.git.viresh.kumar@st.com> @ 2012-04-24 11:21 ` Viresh Kumar 2012-04-24 11:52 ` Wolfram Sang 0 siblings, 1 reply; 2+ messages in thread From: Viresh Kumar @ 2012-04-24 11:21 UTC (permalink / raw) To: akpm Cc: spear-devel, viresh.linux, linux-kernel, linux-arm-kernel, mturquette, sshtylyov, jgarzik, linux, Viresh Kumar, Wolfram Sang, linux-i2c From: Viresh Kumar <viresh.linux@gmail.com> With addition of dummy clk_*() calls for non CONFIG_HAVE_CLK cases in clk.h, there is no need to have clk code enclosed in #ifdef CONFIG_HAVE_CLK, #endif macros. pxa i2c also has these dummy macros defined locally. Remove them as they aren't required anymore. Signed-off-by: Viresh Kumar <viresh.kumar@st.com> Cc: Wolfram Sang <w.sang@pengutronix.de> Cc: linux-i2c@vger.kernel.org --- drivers/i2c/busses/i2c-pxa.c | 7 ------- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c index a997c7d..1034d93 100644 --- a/drivers/i2c/busses/i2c-pxa.c +++ b/drivers/i2c/busses/i2c-pxa.c @@ -41,13 +41,6 @@ #include <asm/irq.h> -#ifndef CONFIG_HAVE_CLK -#define clk_get(dev, id) NULL -#define clk_put(clk) do { } while (0) -#define clk_disable(clk) do { } while (0) -#define clk_enable(clk) do { } while (0) -#endif - struct pxa_reg_layout { u32 ibmr; u32 idbr; -- 1.7.9 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V3 03/12] i2c/i2c-pxa: Remove conditional compilation of clk code 2012-04-24 11:21 ` [PATCH V3 03/12] i2c/i2c-pxa: Remove conditional compilation of clk code Viresh Kumar @ 2012-04-24 11:52 ` Wolfram Sang 0 siblings, 0 replies; 2+ messages in thread From: Wolfram Sang @ 2012-04-24 11:52 UTC (permalink / raw) To: Viresh Kumar Cc: akpm, spear-devel, viresh.linux, linux-kernel, linux-arm-kernel, mturquette, sshtylyov, jgarzik, linux, linux-i2c [-- Attachment #1: Type: text/plain, Size: 782 bytes --] On Tue, Apr 24, 2012 at 04:51:25PM +0530, Viresh Kumar wrote: > From: Viresh Kumar <viresh.linux@gmail.com> > > With addition of dummy clk_*() calls for non CONFIG_HAVE_CLK cases in clk.h, > there is no need to have clk code enclosed in #ifdef CONFIG_HAVE_CLK, #endif > macros. > > pxa i2c also has these dummy macros defined locally. Remove them as they aren't > required anymore. > > Signed-off-by: Viresh Kumar <viresh.kumar@st.com> > Cc: Wolfram Sang <w.sang@pengutronix.de> > Cc: linux-i2c@vger.kernel.org Shall probably not go in via I2C-tree, so: Acked-by: Wolfram Sang <w.sang@pengutronix.de> -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-24 11:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1335266056.git.viresh.kumar@st.com>
2012-04-24 11:21 ` [PATCH V3 03/12] i2c/i2c-pxa: Remove conditional compilation of clk code Viresh Kumar
2012-04-24 11:52 ` Wolfram Sang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).