Re: [PATCH V3 1/2] i2c/adapter: Add bus recovery infrastructure

[Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>]

Hi Wolfram,

On Mon, 23 Apr 2012 14:56:31 +0200, Wolfram Sang wrote:
> On Fri, Mar 02, 2012 at 11:53:42AM +0530, Viresh Kumar wrote:
> > Add i2c bus recovery infrastructure to i2c adapters as specified in the i2c
> > protocol Rev. 03 section 3.16 titled "Bus clear".
> > 
> > http://www.nxp.com/documents/user_manual/UM10204.pdf
> > 
> > Sometimes during operation i2c bus hangs and we need to give dummy clocks to
> > slave device to start the transfer again. Now we may have capability in the bus
> > controller to generate these clocks or platform may have gpio pins which can be
> > toggled to generate dummy clocks. This patch supports both.
> > 
> > This patch also adds in generic bus recovery routines gpio or scl line based
> > which can be used by bus controller. In addition controller driver may provide
> > its own version of the bus recovery routine.
> > 
> > Signed-off-by: Viresh Kumar <viresh.kumar-qxv4g6HH51o@public.gmane.org>
> 
> Finally, a review \o/
> 
> There are some comments regarding the code, but the most important thing
> is to get the interface right.
> 
> Jean, I don't think this is embedded only, so an additional view might
> be helpful here.

I'm afraid I won't have any time for this in a near future. If/when you
are happy with the code, feel free to merge it.

Thanks,
-- 
Jean Delvare