From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Michael Lawnick <ml.lawnick-Mmb7MZpHnFY@public.gmane.org>
Subject: Re: [PATCH] i2c: muxes: rename first set of drivers to a standard pattern
Date: Fri, 27 Apr 2012 09:59:46 +0200 [thread overview]
Message-ID: <20120427095946.50352d3e@endymion.delvare> (raw)
In-Reply-To: <1335386636-23892-1-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
On Wed, 25 Apr 2012 22:43:56 +0200, Wolfram Sang wrote:
> Apply a naming pattern like in the rest of the subsystem to a first set
> of mux drivers. Those drivers are the low-hanging fruit; we want to pick
> them to motivate upcoming drivers to follow the new pattern. The missing
> GPIO driver will be converted in a later patch.
>
> Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> Acked-by: Guenter Roeck <guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org> (pca9541)
> Cc: Michael Lawnick <ml.lawnick-Mmb7MZpHnFY@public.gmane.org>
> Cc: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> ---
> drivers/i2c/muxes/Kconfig | 4 ++--
> drivers/i2c/muxes/Makefile | 4 ++--
> drivers/i2c/muxes/{pca9541.c => i2c-mux-pca9541.c} | 0
> drivers/i2c/muxes/{pca954x.c => i2c-mux-pca954x.c} | 0
> 4 files changed, 4 insertions(+), 4 deletions(-)
> rename drivers/i2c/muxes/{pca9541.c => i2c-mux-pca9541.c} (100%)
> rename drivers/i2c/muxes/{pca954x.c => i2c-mux-pca954x.c} (100%)
Good idea.
Acked-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
(I can pick this in my tree if you want, just let me know.)
Now that you made i2c mux non-experimental, I think it would be great
to solve the gpio mux case quickly. Renaming drivers, header files and
public structures is better done early. I'll give it a try.
--
Jean Delvare
next prev parent reply other threads:[~2012-04-27 7:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 20:43 [PATCH] i2c: muxes: rename first set of drivers to a standard pattern Wolfram Sang
[not found] ` <1335386636-23892-1-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-04-27 7:59 ` Jean Delvare [this message]
[not found] ` <20120427095946.50352d3e-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-04-27 14:05 ` Wolfram Sang
2012-04-27 13:59 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120427095946.50352d3e@endymion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ml.lawnick-Mmb7MZpHnFY@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).