From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH] i2c: mxs: disable QUEUE when sending is done Date: Sat, 28 Apr 2012 12:26:01 +0200 Message-ID: <20120428102601.GO20039@pengutronix.de> References: <1335536631-28202-1-git-send-email-w.sang@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Fabio Estevam Cc: Wolfram Sang , Marek Vasut , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-i2c@vger.kernel.org On Fri, Apr 27, 2012 at 11:51:56AM -0300, Fabio Estevam wrote: > Hi Wolfram, >=20 > On Fri, Apr 27, 2012 at 11:23 AM, Wolfram Sang wrote: >=20 > > =A0 =A0 =A0 =A0if (i2c->cmd_err =3D=3D -ENXIO) > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0mxs_i2c_reset(i2c); > > + =A0 =A0 =A0 else > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 writel(MXS_I2C_QUEUECTRL_QUEUE_RUN, > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 i2c->= regs + MXS_I2C_QUEUECTRL_CLR); >=20 > When setting the QUEUE_RUN, do we really want to clear all the other > bits of QUEUECTRL_CLR register? >=20 > I am wondering if we should only set QUEUE_RUN bit here. I didn't check the manual, but I guess writing to MXS_I2C_QUEUECTRL_CLR just clears the QUEUE_RUN bit and nothing else?! Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig = | Industrial Linux Solutions | http://www.pengutronix.de/= |