From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH 1/2] I2C: Set I2C timing registers for mxs-i2c Date: Mon, 30 Apr 2012 07:58:25 +0200 Message-ID: <20120430055825.GA7926@pengutronix.de> References: <1335738969-27445-1-git-send-email-marex@denx.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/04w6evG8XlLl3ft" Return-path: Content-Disposition: inline In-Reply-To: <1335738969-27445-1-git-send-email-marex-ynQEQJNshbs@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Marek Vasut Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Linux I2C , Detlev Zundel , Fabio Estevam , Stefano Babic , Wolfgang Denk List-Id: linux-i2c@vger.kernel.org --/04w6evG8XlLl3ft Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 30, 2012 at 12:36:08AM +0200, Marek Vasut wrote: > This sets the bus to run at 400kHz, prior to this, > the bus frequency was undefined. Not exactly. The default values let it run at 100kHz. Since not all slaves support 400kHz, I have to NACK this one. Making it configurable is the way to go here. Thanks, Wolfram --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --/04w6evG8XlLl3ft Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAk+eKgEACgkQD27XaX1/VRtlGACgx6XqU9Qj+9me6U2XUCO6DkG7 zcIAnizcHGjOByAo50VC6ZVdXQugSroc =zDmi -----END PGP SIGNATURE----- --/04w6evG8XlLl3ft--