From: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
To: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Linux I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Detlev Zundel <dzu-ynQEQJNshbs@public.gmane.org>,
Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Stefano Babic <sbabic-ynQEQJNshbs@public.gmane.org>,
Wolfgang Denk <wd-ynQEQJNshbs@public.gmane.org>
Subject: Re: [PATCH 1/2] I2C: Set I2C timing registers for mxs-i2c
Date: Mon, 30 Apr 2012 22:09:12 +0200 [thread overview]
Message-ID: <201204302209.12482.marex@denx.de> (raw)
In-Reply-To: <20120430194313.GA28226-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Dear Wolfram Sang,
> > > > This sets the bus to run at 400kHz, prior to this,
> > > > the bus frequency was undefined.
> > >
> > > Not exactly. The default values let it run at 100kHz.
> >
> > Have you tried dumping the default values and comparing it with the
> > values for 100kHz in the manual?
>
> Yes, sure. Doesn't it work for you? I just rechecked and the values are
> okay. That being said, if you make it configurable for 400kHz, it would
> in deed be better to rewrite the values for 100kHz, too.
They were different for me ... did you configure the i2c bus in your bootloader
possibly? Those values might have been written there since then ... I didn't run
i2c in u-boot before booting linux.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-04-30 20:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-29 22:36 [PATCH 1/2] I2C: Set I2C timing registers for mxs-i2c Marek Vasut
[not found] ` <1335738969-27445-1-git-send-email-marex-ynQEQJNshbs@public.gmane.org>
2012-04-29 22:36 ` [PATCH 2/2] I2C: Implement DMA support into mxs-i2c Marek Vasut
[not found] ` <1335738969-27445-2-git-send-email-marex-ynQEQJNshbs@public.gmane.org>
2012-04-30 6:05 ` Wolfram Sang
[not found] ` <20120430060554.GB7926-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-04-30 12:10 ` Marek Vasut
[not found] ` <201204301410.14393.marex-ynQEQJNshbs@public.gmane.org>
2012-04-30 19:52 ` Wolfram Sang
[not found] ` <20120430195221.GB28226-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-04-30 20:07 ` Marek Vasut
[not found] ` <201204302207.39112.marex-ynQEQJNshbs@public.gmane.org>
2012-04-30 20:30 ` Wolfram Sang
[not found] ` <20120430203016.GD28226-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-04-30 20:45 ` Marek Vasut
[not found] ` <201204302245.57958.marex-ynQEQJNshbs@public.gmane.org>
2012-04-30 21:01 ` Wolfram Sang
[not found] ` <20120430210108.GE28226-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-04-30 21:19 ` Marek Vasut
2012-05-01 13:58 ` Shawn Guo
[not found] ` <20120501135800.GL2194-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2012-05-01 14:02 ` Marek Vasut
[not found] ` <201205011602.56563.marex-ynQEQJNshbs@public.gmane.org>
2012-05-01 14:09 ` Shawn Guo
[not found] ` <20120501140910.GM2194-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2012-05-01 14:14 ` Marek Vasut
2012-05-01 14:37 ` Russell King - ARM Linux
2012-04-30 5:58 ` [PATCH 1/2] I2C: Set I2C timing registers for mxs-i2c Wolfram Sang
[not found] ` <20120430055825.GA7926-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-04-30 12:05 ` Marek Vasut
[not found] ` <201204301405.42621.marex-ynQEQJNshbs@public.gmane.org>
2012-04-30 19:43 ` Wolfram Sang
[not found] ` <20120430194313.GA28226-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-04-30 20:09 ` Marek Vasut [this message]
[not found] ` <201204302209.12482.marex-ynQEQJNshbs@public.gmane.org>
2012-04-30 20:27 ` Wolfram Sang
[not found] ` <20120430202742.GC28226-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-04-30 20:47 ` Marek Vasut
[not found] ` <201204302247.17242.marex-ynQEQJNshbs@public.gmane.org>
2012-04-30 21:02 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204302209.12482.marex@denx.de \
--to=marex-ynqeqjnshbs@public.gmane.org \
--cc=dzu-ynQEQJNshbs@public.gmane.org \
--cc=festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sbabic-ynQEQJNshbs@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=wd-ynQEQJNshbs@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).