Re: [PATCH V3] i2c: Add generic I2C multiplexer using pinctrl API

[Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1744 bytes --]

On Tue, May 01, 2012 at 11:23:31AM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> 
> This is useful for SoCs whose I2C module's signals can be routed to
> different sets of pins at run-time, using the pinctrl API.
> 
>                                  +-----+  +-----+
>                                  | dev |  | dev |
>     +------------------------+   +-----+  +-----+
>     | SoC                    |      |        |
>     |                   /----|------+--------+
>     |   +---+   +------+     | child bus A, on first set of pins
>     |   |I2C|---|Pinmux|     |
>     |   +---+   +------+     | child bus B, on second set of pins
>     |                   \----|------+--------+--------+
>     |                        |      |        |        |
>     +------------------------+  +-----+  +-----+  +-----+
>                                 | dev |  | dev |  | dev |
>                                 +-----+  +-----+  +-----+
> 
> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> Acked-by: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
> v3: Renamed pinctrl-i2cmux.c to i2c-mux-pinctrl.c to match recent changes
>     to other I2C mux files.

Thanks for doing the rename already. While I think I could follow your
argument regarding the compatible-binding, I'd still like to have an ack
from one of the device tree maintainers. The bindings are non-trivial
and I am missing the insight to judge them.

Thanks,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]