From: Tony Lindgren <tony@atomide.com>
To: Shubhrajyoti <shubhrajyoti@ti.com>
Cc: linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, ben-linux@fluff.org,
w.sang@pengutronix.de
Subject: Re: [PATCHv8 03/13] I2C: OMAP: Remove reset at init
Date: Thu, 21 Jun 2012 00:20:00 -0700 [thread overview]
Message-ID: <20120621071959.GV12766@atomide.com> (raw)
In-Reply-To: <4FE2C750.3020803@ti.com>
* Shubhrajyoti <shubhrajyoti@ti.com> [120621 00:08]:
> On Wednesday 20 June 2012 03:59 PM, Tony Lindgren wrote:
> > See the comments regarding driver specific resets in hwmod code.
> you mean omap_hwmod.c
> >
> > The way to set this up is to have a shared inline function in
> > i2c-omap.h that both the driver and hwmod code can use.
> hwmod reset function uses oh (omap_hwmod).
>
> How could the driver also pass oh ?
> Could we keep a local copy in driver data?
> > Eventually hwmod code will do the reset only in late initcall
> > if no driver is loaded for the device in question.
>
There's no need for the driver to know anything about oh.
The driver just needs to know the iobase.
Tony
next prev parent reply other threads:[~2012-06-21 7:20 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 14:30 [PATCHv8 00/13] I2C cleanups Shubhrajyoti D
2012-06-18 14:30 ` [PATCHv8 01/13] I2C: OMAP: I2C register restore only if context is lost Shubhrajyoti D
2012-06-18 14:30 ` [PATCHv8 02/13] I2C: OMAP: Remove the definition of SYSS_RESETDONE_MASK Shubhrajyoti D
[not found] ` <1340029828-20751-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-06-18 14:30 ` [PATCHv8 03/13] I2C: OMAP: Remove reset at init Shubhrajyoti D
2012-06-20 10:29 ` Tony Lindgren
[not found] ` <20120620102905.GC12766-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2012-06-21 7:03 ` Shubhrajyoti
2012-06-21 7:20 ` Tony Lindgren [this message]
2012-06-21 9:30 ` Shubhrajyoti
[not found] ` <4FE2E9D3.5060304-l0cyMroinI0@public.gmane.org>
2012-06-26 11:15 ` Tony Lindgren
2012-06-18 14:30 ` [PATCHv8 04/13] I2C: OMAP: Recover from Bus Busy condition Shubhrajyoti D
2012-06-18 14:30 ` [PATCHv8 06/13] I2C: OMAP: Correct I2C revision for OMAP3 Shubhrajyoti D
[not found] ` <1340029828-20751-7-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-06-20 10:32 ` Tony Lindgren
2012-06-20 13:01 ` Shubhrajyoti
[not found] ` <4FE1C9AC.3020104-l0cyMroinI0@public.gmane.org>
2012-06-20 14:14 ` Tony Lindgren
[not found] ` <20120620141437.GN12766-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2012-06-21 6:56 ` Shubhrajyoti Datta
2012-06-18 14:30 ` [PATCHv8 07/13] I2C: OMAP: use devm_* functions Shubhrajyoti D
2012-06-18 14:30 ` [PATCHv8 08/13] I2C: OMAP: Use SET_RUNTIME_PM_OPS Shubhrajyoti D
2012-06-18 14:30 ` [PATCHv8 10/13] I2C: OMAP: simplify num_bytes handling Shubhrajyoti D
[not found] ` <1340029828-20751-11-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-06-18 15:22 ` Wolfram Sang
2012-06-18 14:30 ` [PATCHv8 11/13] I2C: OMAP: decrease indentation level on data handling Shubhrajyoti D
2012-06-18 15:25 ` Wolfram Sang
2012-06-18 14:30 ` [PATCHv8 13/13] I2C: OMAP: simplify omap_i2c_ack_stat() Shubhrajyoti D
[not found] ` <1340029828-20751-14-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-06-18 15:30 ` Wolfram Sang
[not found] ` <20120618153000.GC10768-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-06-19 9:20 ` Shubhrajyoti Datta
2012-06-19 13:33 ` Wolfram Sang
2012-06-18 15:33 ` [PATCHv8 00/13] I2C cleanups Wolfram Sang
2012-06-18 14:30 ` [PATCHv8 05/13] I2C: OMAP: Optimise the remove code Shubhrajyoti D
2012-06-18 14:30 ` [PATCHv8 09/13] I2C: OMAP: Do not initialise the completion everytime Shubhrajyoti D
2012-06-18 14:30 ` [PATCHv8 12/13] I2C: OMAP: add blank lines Shubhrajyoti D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120621071959.GV12766@atomide.com \
--to=tony@atomide.com \
--cc=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=shubhrajyoti@ti.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).