From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: Re: [PATCH 1/2 V3] MXS: Set I2C timing registers for mxs-i2c Date: Wed, 27 Jun 2012 03:15:58 +0200 Message-ID: <201206270315.58872.marex@denx.de> References: <1339242351-8797-1-git-send-email-marex@denx.de> <201206232047.33228.marex@denx.de> <20120625154354.GC2342@S2101-09.ap.freescale.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120625154354.GC2342-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Shawn Guo Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Detlev Zundel , Dong Aisheng , Fabio Estevam , Linux ARM kernel , Sascha Hauer , Stefano Babic , Uwe =?iso-8859-1?q?Kleine-K=F6nig?= , Wolfgang Denk , Wolfram Sang List-Id: linux-i2c@vger.kernel.org Dear Shawn Guo, > On Sat, Jun 23, 2012 at 08:47:32PM +0200, Marek Vasut wrote: > > Dear Shawn Guo, > > > > > This patch configures the I2C bus timing registers according > > > to information passed via DT. Currently, 100kHz and 400kHz > > > modes are supported. > > > > [...] > > > > Is there any reason why this can not be merged other than the timing > > registers goo (which I believe shall stay as in the datasheet until we > > figure out if it's even reasonable to add some computation there). > > I assume this is a question for Wolfram. But I guess part of the reason > is there is still one comment from me staying unresolved. Shawn, I just re-tested the i2c with mpg123 playing "MPEG 1.0 layer III, VBR, 44100 Hz joint-stereo" and it worked on a first try ... can you retest please? Best regards, Marek Vasut