Re: [PATCH 2/2] MXS: Implement DMA support into mxs-i2c

[Dong Aisheng <aisheng.dong-KZfg59tc24xl57MIdRCFDg@public.gmane.org>]

On Fri, Jun 29, 2012 at 05:30:16PM +0800, Marek Vasut wrote:
> Dear Dong Aisheng,
> 
> > On Fri, Jun 29, 2012 at 04:24:03PM +0800, Marek Vasut wrote:
> > > This patch implements DMA support into mxs-i2c. DMA transfers are now
> > > enabled via DT. The DMA operation is enabled by default.
> > > 
> > > Signed-off-by: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
> > > Cc: Detlev Zundel <dzu-ynQEQJNshbs@public.gmane.org>
> > > CC: Dong Aisheng <b29396-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > > CC: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > > Cc: Linux ARM kernel <linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
> > > Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > > CC: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> > > CC: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > > Cc: Stefano Babic <sbabic-ynQEQJNshbs@public.gmane.org>
> > > CC: Uwe Kleine-König <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> > > Cc: Wolfgang Denk <wd-ynQEQJNshbs@public.gmane.org>
> > > Cc: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> > > ---
> > > 
> > >  Documentation/devicetree/bindings/i2c/i2c-mxs.txt |    4 +
> > >  arch/arm/boot/dts/imx28.dtsi                      |    2 +
> > >  drivers/i2c/busses/i2c-mxs.c                      |  267
> > >  +++++++++++++++++++-- 3 files changed, 251 insertions(+), 22
> > >  deletions(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mxs.txt
> > > b/Documentation/devicetree/bindings/i2c/i2c-mxs.txt index
> > > d2bf750..9497ee0 100644
> > > --- a/Documentation/devicetree/bindings/i2c/i2c-mxs.txt
> > > +++ b/Documentation/devicetree/bindings/i2c/i2c-mxs.txt
> > > 
> > > @@ -5,6 +5,10 @@ Required properties:
> > >  - reg: Should contain registers location and length
> > >  - interrupts: Should contain ERROR and DMA interrupts
> > >  - clock-frequency: desired I2C bus clock frequency in Hz.
> > > 
> > > +- fsl,i2c-dma-channel: APBX DMA channel for the I2C
> > 
> > Shoundn't this be optional?
> 
> DMA channel? No, why?
> 
User can use pio mode, so actually it's optional.
Is it reasonable?

> > 
> > > +	/*
> > > +	 * The last descriptor must have this callback,
> > > +	 * to finish the DMA transaction.
> > > +	 */
> > > +	desc->callback = mxs_i2c_dma_irq_callback;
> > > +	desc->callback_param = i2c;
> > > +
> > > +	/* Start the transfer. */
> > > +	dmaengine_submit(desc);
> > > +	dma_async_issue_pending(i2c->dmach);
> > > +	return 0;
> > > +
> > > +/* Read failpath. */
> > > +read_init_dma_fail:
> > > +	dma_unmap_sg(i2c->dev, &i2c->sg_io[1], 1, DMA_FROM_DEVICE);
> > > +select_init_dma_fail:
> > > +	dma_unmap_sg(i2c->dev, &i2c->sg_io[0], 1, DMA_TO_DEVICE);
> > > +select_init_pio_fail:
> > > +	return 1;
> > 
> > look strange why return 1;
> 
> Because it failed. -Esomething might be better ?
> 
i think yes.

Regards
Dong Aisheng