From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH 14/15] i2c: iop3xx: use standard gpiolib functions Date: Sun, 8 Jul 2012 13:29:03 +0200 Message-ID: <20120708112903.GB18362@pengutronix.de> References: <1341600040-30993-1-git-send-email-robherring2@gmail.com> <1341600040-30993-15-git-send-email-robherring2@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3lcZGd9BuhuYXNfi" Return-path: Content-Disposition: inline In-Reply-To: <1341600040-30993-15-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Arnd Bergmann , Olof Johansson , Nicolas Pitre , Andrew Lunn , Colin Cross , Jason Cooper , thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org, bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, Stephen Warren , Russell King , Rob Herring , "Jean Delvare (PC drivers, core)" , "Ben Dooks (embedded platforms)" , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org --3lcZGd9BuhuYXNfi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 06, 2012 at 01:40:39PM -0500, Rob Herring wrote: > From: Rob Herring >=20 > Instead of using the custom iop3xx gpio functions, use the gpiolib > variants. This should be functionally the same since the gpiolib > just calls the iop3xx gpio functions. This is needed in preparation > of removing iop3xx mach/io.h headers. >=20 > Signed-off-by: Rob Herring > Cc: "Jean Delvare (PC drivers, core)" > Cc: "Ben Dooks (embedded platforms)" > Cc: "Wolfram Sang (embedded platforms)" > Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Is this dependent on another patch from this series? Or can this go via the I2C tree? I am fine with just acking this one, but the whitespace removal should better go via I2C I think. Thanks, Wolfram > --- > drivers/i2c/busses/i2c-iop3xx.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/i2c/busses/i2c-iop3xx.c b/drivers/i2c/busses/i2c-iop= 3xx.c > index 567d873..2f99613 100644 > --- a/drivers/i2c/busses/i2c-iop3xx.c > +++ b/drivers/i2c/busses/i2c-iop3xx.c > @@ -39,6 +39,7 @@ > #include > #include > #include > +#include > =20 > #include "i2c-iop3xx.h" > =20 > @@ -78,11 +79,11 @@ iop3xx_i2c_enable(struct i2c_algo_iop3xx_data *iop3xx= _adap) > */ > #if defined(CONFIG_ARCH_IOP32X) || defined(CONFIG_ARCH_IOP33X) > if (iop3xx_adap->id =3D=3D 0) { > - gpio_line_set(IOP3XX_GPIO_LINE(7), GPIO_LOW); > - gpio_line_set(IOP3XX_GPIO_LINE(6), GPIO_LOW); > + gpio_set_value(7, 0); > + gpio_set_value(6, 0); > } else { > - gpio_line_set(IOP3XX_GPIO_LINE(5), GPIO_LOW); > - gpio_line_set(IOP3XX_GPIO_LINE(4), GPIO_LOW); > + gpio_set_value(5, 0); > + gpio_set_value(4, 0); > } > #endif > /* NB SR bits not same position as CR IE bits :-( */ > --=20 > 1.7.9.5 >=20 --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --3lcZGd9BuhuYXNfi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAk/5bv8ACgkQD27XaX1/VRsJBACgl315Yif6JGLd1rYMSR0RAFKN GsgAn02tSzUm91GVZ2qC/4X7qG7FVVmP =xScB -----END PGP SIGNATURE----- --3lcZGd9BuhuYXNfi--