[PATCH] i2c: imx: make bitrate unsigned int

[PATCH] i2c: imx: make bitrate unsigned int

[Wolfram Sang]

sparse found this assignment of u32 to an int. Fix it:

drivers/i2c/busses/i2c-imx.c:540:56: warning: incorrect type in argument 3 (different signedness)

Signed-off-by: Wolfram Sang <wolfram-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Cc: Richard Zhao <richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
---
 drivers/i2c/busses/i2c-imx.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index a93e846..3f5dfe8 100644
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -471,8 +471,8 @@ static int __init i2c_imx_probe(struct platform_device *pdev)
 	struct imxi2c_platform_data *pdata = pdev->dev.platform_data;
 	struct pinctrl *pinctrl;
 	void __iomem *base;
-	int irq, bitrate;
-	int ret;
+	int irq, ret;
+	u32 bitrate;
 
 	dev_dbg(&pdev->dev, "<%s>\n", __func__);
 
-- 
1.7.10

Re: [PATCH] i2c: imx: make bitrate unsigned int

[Richard Zhao]

On Sun, Jul 08, 2012 at 01:24:47PM +0200, Wolfram Sang wrote:
> sparse found this assignment of u32 to an int. Fix it:
> 
> drivers/i2c/busses/i2c-imx.c:540:56: warning: incorrect type in argument 3 (different signedness)
Could you change imxi2c_platform_data.bitrate to unsigned int too?

Thanks
Richard
> 
> Signed-off-by: Wolfram Sang <wolfram-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
> Cc: Richard Zhao <richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> ---
>  drivers/i2c/busses/i2c-imx.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index a93e846..3f5dfe8 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -471,8 +471,8 @@ static int __init i2c_imx_probe(struct platform_device *pdev)
>  	struct imxi2c_platform_data *pdata = pdev->dev.platform_data;
>  	struct pinctrl *pinctrl;
>  	void __iomem *base;
> -	int irq, bitrate;
> -	int ret;
> +	int irq, ret;
> +	u32 bitrate;
>  
>  	dev_dbg(&pdev->dev, "<%s>\n", __func__);
>  
> -- 
> 1.7.10
> 
> 

Re: [PATCH] i2c: imx: make bitrate unsigned int

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 549 bytes --]

On Mon, Jul 09, 2012 at 02:24:29PM +0800, Richard Zhao wrote:
> On Sun, Jul 08, 2012 at 01:24:47PM +0200, Wolfram Sang wrote:
> > sparse found this assignment of u32 to an int. Fix it:
> > 
> > drivers/i2c/busses/i2c-imx.c:540:56: warning: incorrect type in argument 3 (different signedness)
> Could you change imxi2c_platform_data.bitrate to unsigned int too?

Good point, thanks!

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]