linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Linux PM list <linux-pm@vger.kernel.org>,
	Linus Walleij <linus.walleij@stericsson.com>,
	linux-i2c@vger.kernel.org, Sonic Zhang <sonic.zhang@analog.com>,
	Jean Delvare <khali@linux-fr.org>,
	Ben Dooks <ben-linux@fluff.org>,
	Wolfram Sang <w.sang@pengutronix.de>,
	Peter Korsgaard <jacmet@sunsite.dk>,
	Guan Xuetao <gxt@mprc.pku.edu.cn>,
	Vitaly Wool <vitalywool@gmail.com>,
	Colin Cross <ccross@android.com>,
	Stephen Warren <swarren@wwwdotorg.org>
Subject: [PATCH 6/7] i2c-stu300: Use struct dev_pm_ops for power management
Date: Wed, 11 Jul 2012 21:26:36 +0200	[thread overview]
Message-ID: <201207112126.36412.rjw@sisk.pl> (raw)
In-Reply-To: <201207112121.11046.rjw@sisk.pl>

From: Rafael J. Wysocki <rjw@sisk.pl>

Make the ST-Ericsson U300 I2C controller driver define its PM
callbacks through a struct dev_pm_ops object rather than by using
legacy PM hooks in struct platform_driver.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
 drivers/i2c/busses/i2c-stu300.c |   19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

Index: linux/drivers/i2c/busses/i2c-stu300.c
===================================================================
--- linux.orig/drivers/i2c/busses/i2c-stu300.c
+++ linux/drivers/i2c/busses/i2c-stu300.c
@@ -978,31 +978,33 @@ stu300_probe(struct platform_device *pde
 }
 
 #ifdef CONFIG_PM
-static int stu300_suspend(struct platform_device *pdev, pm_message_t state)
+static int stu300_suspend(struct device *device)
 {
-	struct stu300_dev *dev = platform_get_drvdata(pdev);
+	struct stu300_dev *dev = dev_get_drvdata(device);
 
 	/* Turn off everything */
 	stu300_wr8(0x00, dev->virtbase + I2C_CR);
 	return 0;
 }
 
-static int stu300_resume(struct platform_device *pdev)
+static int stu300_resume(struct device *device)
 {
 	int ret = 0;
-	struct stu300_dev *dev = platform_get_drvdata(pdev);
+	struct stu300_dev *dev = dev_get_drvdata(device);
 
 	clk_enable(dev->clk);
 	ret = stu300_init_hw(dev);
 	clk_disable(dev->clk);
 
 	if (ret != 0)
-		dev_err(&pdev->dev, "error re-initializing hardware.\n");
+		dev_err(device, "error re-initializing hardware.\n");
 	return ret;
 }
+
+static SIMPLE_DEV_PM_OPS(stu300_pm, stu300_suspend, stu300_resume);
+#define STU300_I2C_PM	(&stu300_pm)
 #else
-#define stu300_suspend NULL
-#define stu300_resume NULL
+#define STU300_I2C_PM	NULL
 #endif
 
 static int __exit
@@ -1026,10 +1028,9 @@ static struct platform_driver stu300_i2c
 	.driver = {
 		.name	= NAME,
 		.owner	= THIS_MODULE,
+		.pm	= STU300_I2C_PM,
 	},
 	.remove		= __exit_p(stu300_remove),
-	.suspend        = stu300_suspend,
-	.resume         = stu300_resume,
 
 };
 

  parent reply	other threads:[~2012-07-11 19:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-11 19:21 [PATCH 0/7] PM / I2C: Convert platform I2C drivers to PM handling based on struct dev_pm_ops Rafael J. Wysocki
2012-07-11 19:22 ` [PATCH 1/7] i2c-at91: Use struct dev_pm_ops for power management Rafael J. Wysocki
2012-07-11 19:23 ` [PATCH 2/7] i2c-bfin-twi: " Rafael J. Wysocki
2012-07-12  2:51   ` Zhang, Sonic
2012-07-11 19:24 ` [PATCH 3/7] i2c-ocores: " Rafael J. Wysocki
2012-07-11 19:25 ` [PATCH 5/7] i2c-puv3: " Rafael J. Wysocki
2012-07-12  3:24   ` guanxuetao
2012-07-11 19:26 ` Rafael J. Wysocki [this message]
     [not found]   ` <201207112126.36412.rjw-KKrjLPT3xs0@public.gmane.org>
2012-07-11 21:56     ` [PATCH 6/7] i2c-stu300: " Linus Walleij
2012-07-11 19:27 ` [PATCH 7/7] i2c-tegra: " Rafael J. Wysocki
     [not found] ` <201207112121.11046.rjw-KKrjLPT3xs0@public.gmane.org>
2012-07-11 19:25   ` [PATCH 4/7] i2c-pnx: " Rafael J. Wysocki
2012-07-12  6:00   ` [PATCH 0/7] PM / I2C: Convert platform I2C drivers to PM handling based on struct dev_pm_ops Laxman Dewangan
2012-07-12 10:09 ` Wolfram Sang
2012-07-12 10:17   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201207112126.36412.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=ben-linux@fluff.org \
    --cc=ccross@android.com \
    --cc=gxt@mprc.pku.edu.cn \
    --cc=jacmet@sunsite.dk \
    --cc=khali@linux-fr.org \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=sonic.zhang@analog.com \
    --cc=swarren@wwwdotorg.org \
    --cc=vitalywool@gmail.com \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).