* [PATCH] i2c-mv64xxxx: allow more than one driver instance
@ 2012-07-08 15:53 Florian Fainelli
[not found] ` <1341762785-6918-1-git-send-email-ffainelli-MmRyKUhfbQ9GWvitb5QawA@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Florian Fainelli @ 2012-07-08 15:53 UTC (permalink / raw)
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA
Cc: ben-linux-elnMNo+KYs3YtjvyW6yDsg, w.sang-bIcnvbaLZ9MEGnE8C9+IrQ,
Florian Fainelli, Andrew Lunn, Nicolas Schichan
The driver currently checks the platform device id and rejects platform
device id different from 0. This prevents the registration of a second
i2c controller on systems where a second one might be available (such as
Kirkwood 88F6282).
CC: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
Signed-off-by: Nicolas Schichan <nschichan-MmRyKUhfbQ9GWvitb5QawA@public.gmane.org>
Signed-off-by: Florian Fainelli <ffainelli-MmRyKUhfbQ9GWvitb5QawA@public.gmane.org>
---
drivers/i2c/busses/i2c-mv64xxx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c
index 4f44a33..6e70eea 100644
--- a/drivers/i2c/busses/i2c-mv64xxx.c
+++ b/drivers/i2c/busses/i2c-mv64xxx.c
@@ -528,7 +528,7 @@ mv64xxx_i2c_probe(struct platform_device *pd)
struct mv64xxx_i2c_pdata *pdata = pd->dev.platform_data;
int rc;
- if ((pd->id != 0) || !pdata)
+ if (!pdata)
return -ENODEV;
drv_data = kzalloc(sizeof(struct mv64xxx_i2c_data), GFP_KERNEL);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] i2c-mv64xxxx: allow more than one driver instance
[not found] ` <1341762785-6918-1-git-send-email-ffainelli-MmRyKUhfbQ9GWvitb5QawA@public.gmane.org>
@ 2012-07-12 13:53 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2012-07-12 13:53 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA,
ben-linux-elnMNo+KYs3YtjvyW6yDsg, Andrew Lunn, Nicolas Schichan
[-- Attachment #1: Type: text/plain, Size: 840 bytes --]
On Sun, Jul 08, 2012 at 05:53:05PM +0200, Florian Fainelli wrote:
> The driver currently checks the platform device id and rejects platform
> device id different from 0. This prevents the registration of a second
> i2c controller on systems where a second one might be available (such as
> Kirkwood 88F6282).
>
> CC: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
> Signed-off-by: Nicolas Schichan <nschichan-MmRyKUhfbQ9GWvitb5QawA@public.gmane.org>
> Signed-off-by: Florian Fainelli <ffainelli-MmRyKUhfbQ9GWvitb5QawA@public.gmane.org>
Applied to next, thanks.
How are your experiences with the driver? Does it still need
EXPERIMENTAL?
Thanks,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-12 13:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-08 15:53 [PATCH] i2c-mv64xxxx: allow more than one driver instance Florian Fainelli
[not found] ` <1341762785-6918-1-git-send-email-ffainelli-MmRyKUhfbQ9GWvitb5QawA@public.gmane.org>
2012-07-12 13:53 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).