From: Jean Delvare <khali@linux-fr.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: "Amaury Decrême" <amaury.decreme@gmail.com>,
linux-i2c@vger.kernel.org, amalysh@web.de, nelson@sis.com,
ben-linux@fluff.org, w.sang@pengutronix.de, rob@landley.net,
jeffrey.t.kirsher@intel.com, akpm@linux-foundation.org,
davem@davemloft.net, joe@perches.com, ralf@linux-mips.org,
dirk.brandewie@gmail.com, jayachandranc@netlogicmicro.com,
Xiangzhen.Ye@csr.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
suzanne.decreme@gmail.com
Subject: Re: [PATCH] i2c: sis964: bus driver
Date: Sun, 15 Jul 2012 13:35:30 +0200 [thread overview]
Message-ID: <20120715133530.1ffc3f36@endymion.delvare> (raw)
In-Reply-To: <CAErSpo5-ou3vjmHgjiOOd57PvWg_hez80U0k3AX_ydjb0pikvQ@mail.gmail.com>
Hi Bjorn,
On Fri, 13 Jul 2012 09:36:07 -0600, Bjorn Helgaas wrote:
> On Fri, Jul 13, 2012 at 3:40 AM, Amaury Decrême
> <amaury.decreme@gmail.com> wrote:
> > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> > index ab741b0..0ffc982 100644
> > --- a/include/linux/pci_ids.h
> > +++ b/include/linux/pci_ids.h
> > @@ -699,6 +699,7 @@
> > #define PCI_DEVICE_ID_SI_961 0x0961
> > #define PCI_DEVICE_ID_SI_962 0x0962
> > #define PCI_DEVICE_ID_SI_963 0x0963
> > +#define PCI_DEVICE_ID_SI_964 0x0964
>
> Please read the comment at the top of this file; I don't think this
> addition qualifies as something that should be added.
>
> > #define PCI_DEVICE_ID_SI_965 0x0965
> > #define PCI_DEVICE_ID_SI_966 0x0966
> > #define PCI_DEVICE_ID_SI_968 0x0968
When you reply to a large patch, please limit the quoting to the
relevant portion.
Thanks,
--
Jean Delvare
next prev parent reply other threads:[~2012-07-15 11:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 9:40 [PATCH] i2c: sis964: bus driver Amaury Decrême
2012-07-13 15:36 ` Bjorn Helgaas
[not found] ` <CAErSpo5-ou3vjmHgjiOOd57PvWg_hez80U0k3AX_ydjb0pikvQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-07-14 7:53 ` Amaury Decrême
2012-07-15 11:35 ` Jean Delvare [this message]
[not found] ` <20120715133530.1ffc3f36-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-07-18 11:57 ` Amaury Decrême
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120715133530.1ffc3f36@endymion.delvare \
--to=khali@linux-fr.org \
--cc=Xiangzhen.Ye@csr.com \
--cc=akpm@linux-foundation.org \
--cc=amalysh@web.de \
--cc=amaury.decreme@gmail.com \
--cc=ben-linux@fluff.org \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=dirk.brandewie@gmail.com \
--cc=jayachandranc@netlogicmicro.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=joe@perches.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=nelson@sis.com \
--cc=ralf@linux-mips.org \
--cc=rob@landley.net \
--cc=suzanne.decreme@gmail.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).