Re: [RFC/PATCH 1/3] i2c: Add SCCB support

[Jean Delvare <khali@linux-fr.org>]

On Tue, 17 Jul 2012 13:57:25 +0200, Laurent Pinchart wrote:
> On Tuesday 17 July 2012 13:53:07 Jean Delvare wrote:
> > On Tue, 26 Jun 2012 16:17:07 +0200, Laurent Pinchart wrote:
> > > +	if (unlikely(flags & I2C_CLIENT_SCCB) && size != I2C_SMBUS_BYTE_DATA) {
> > > +		dev_err(&adapter->dev,
> > > +			"SCCB devices only support I2C_SMBUS_BYTE_DATA\n");
> > > +		return -EINVAL;
> > > +	}
> > > +
> > 
> > I'm not sure if we really want this. If the SCCB protocol evolves,
> > we'll have to loosen the check. If a devices follows SCCB for byte data
> > transactions and I2C/SMBus for others, it won't work. Plus it slows
> > down the function a bit, to catch a developer error which would not
> > result in anything catastrophic anyway.
> > 
> > I propose that we either drop the check completely (my preference) or
> > make it depend on DEBUG.
> 
> I'm OK with dropping the check. Should I resubmit the patch or can you modify 
> it when applying ?

I'll do it myself, no problem.

Thanks,
-- 
Jean Delvare