Re: [RFC/PATCH 3/3] i2c: omap: Add support for I2C_M_STOP message flag

[Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>]

On Tue, 26 Jun 2012 16:17:09 +0200, Laurent Pinchart wrote:
> Generate a stop condition after each message marked with I2C_M_STOP.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
> ---
>  drivers/i2c/busses/i2c-omap.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index 801df60..cf1bda0 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -545,6 +545,8 @@ static int omap_i2c_xfer_msg(struct i2c_adapter *adap,
>  	if (dev->speed > 400)
>  		w |= OMAP_I2C_CON_OPMODE_HS;
>  
> +	if (msg->flags & I2C_M_STOP)
> +		stop = 1;
>  	if (msg->flags & I2C_M_TEN)
>  		w |= OMAP_I2C_CON_XA;
>  	if (!(msg->flags & I2C_M_RD))

Looks OK to me, but I can't test it, and I also don't know a thing
about OMAP. Maybe it would be a good idea to let omap_i2c_func() return
I2C_FUNC_PROTOCOL_MANGLING now?

-- 
Jean Delvare