* [PATCH v2] i2c: convert struct i2c_msg initialization to C99 format
@ 2012-08-06 8:57 Shubhrajyoti D
[not found] ` <1344243467-7237-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Shubhrajyoti D @ 2012-08-06 8:57 UTC (permalink / raw)
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA; +Cc: Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes
maintaining and editing the code simpler. Also helps once other fields
like transferred are added in future.
Signed-off-by: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
---
drivers/i2c/i2c-core.c | 17 ++++++++++++++---
1 files changed, 14 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index 2efa56c..c77a1ac 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -1971,12 +1971,23 @@ static s32 i2c_smbus_xfer_emulated(struct i2c_adapter *adapter, u16 addr,
unsigned char msgbuf0[I2C_SMBUS_BLOCK_MAX+3];
unsigned char msgbuf1[I2C_SMBUS_BLOCK_MAX+2];
int num = read_write == I2C_SMBUS_READ ? 2 : 1;
- struct i2c_msg msg[2] = { { addr, flags, 1, msgbuf0 },
- { addr, flags | I2C_M_RD, 0, msgbuf1 }
- };
int i;
u8 partial_pec = 0;
int status;
+ struct i2c_msg msg[2] = {
+ {
+ .addr = addr,
+ .flags = flags,
+ .len = 1,
+ .buf = msgbuf0,
+ },
+ {
+ .addr = addr,
+ .flags = flags | I2C_M_RD,
+ .len = 0,
+ .buf = msgbuf1,
+ },
+ };
msgbuf0[0] = command;
switch (size) {
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] i2c: convert struct i2c_msg initialization to C99 format
[not found] ` <1344243467-7237-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
@ 2012-08-06 14:12 ` Jean Delvare
0 siblings, 0 replies; 2+ messages in thread
From: Jean Delvare @ 2012-08-06 14:12 UTC (permalink / raw)
To: Shubhrajyoti D; +Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA
On Mon, 6 Aug 2012 14:27:47 +0530, Shubhrajyoti D wrote:
> Convert the struct i2c_msg initialization to C99 format. This makes
> maintaining and editing the code simpler. Also helps once other fields
> like transferred are added in future.
>
> Signed-off-by: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
> ---
> drivers/i2c/i2c-core.c | 17 ++++++++++++++---
> 1 files changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
> index 2efa56c..c77a1ac 100644
> --- a/drivers/i2c/i2c-core.c
> +++ b/drivers/i2c/i2c-core.c
> @@ -1971,12 +1971,23 @@ static s32 i2c_smbus_xfer_emulated(struct i2c_adapter *adapter, u16 addr,
> unsigned char msgbuf0[I2C_SMBUS_BLOCK_MAX+3];
> unsigned char msgbuf1[I2C_SMBUS_BLOCK_MAX+2];
> int num = read_write == I2C_SMBUS_READ ? 2 : 1;
> - struct i2c_msg msg[2] = { { addr, flags, 1, msgbuf0 },
> - { addr, flags | I2C_M_RD, 0, msgbuf1 }
> - };
> int i;
> u8 partial_pec = 0;
> int status;
> + struct i2c_msg msg[2] = {
> + {
> + .addr = addr,
> + .flags = flags,
> + .len = 1,
> + .buf = msgbuf0,
> + },
> + {
> + .addr = addr,
> + .flags = flags | I2C_M_RD,
> + .len = 0,
> + .buf = msgbuf1,
> + },
> + };
>
> msgbuf0[0] = command;
> switch (size) {
Applied, thanks.
--
Jean Delvare
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-06 14:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-06 8:57 [PATCH v2] i2c: convert struct i2c_msg initialization to C99 format Shubhrajyoti D
[not found] ` <1344243467-7237-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-08-06 14:12 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).