From: Lee Jones <lee.jones@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
STEricsson_nomadik_linux@list.st.com,
linus.walleij@stericsson.com, arnd@arndb.de,
w.sang@pengutronix.de, linux-i2c@vger.kernel.org
Subject: Re: [PATCH 1/1 v2] i2c: Add default configuration into the Nomadik I2C driver.
Date: Tue, 7 Aug 2012 12:41:15 +0100 [thread overview]
Message-ID: <20120807114113.GA5684@gmail.com> (raw)
In-Reply-To: <CACRpkdZjbyQbht+UpXrrVGhAzGYPjb=HRZhJ+TvsEXhGeviJLA@mail.gmail.com>
> > diff --git a/drivers/gpu/mali/mali400ko/driver/src/devicedrv/mali/arch b/drivers/gpu/mali/mali400ko/driver/src/devicedrv/mali/arch
> > new file mode 120000
> > index 0000000..427334b
> > --- /dev/null
> > +++ b/drivers/gpu/mali/mali400ko/driver/src/devicedrv/mali/arch
> > @@ -0,0 +1 @@
>
> NACK, what is this stuff? It's even out-of-tree code.
Whoa, no idea! Good spot though, I missed this completely.
> Please be careful with git add -A, I prefer to use git add <pathspec>
> I suspect that may be why this happened...
I don't use `git add -A`, ever. If I'm adding files, I usually use
`git commit -s -- <pathspec>`, or `git commit -a` if I'm sure I require
all the necessary changes. I guess I could have accidentally collected
it using `git add -i` whist fixing it up, or a similar misdemeanor.
> Please fix it up and send a v3.
Of course.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2012-08-07 11:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 15:17 [PATCH 1/1] i2c: Add default configuration into the Nomadik I2C driver Lee Jones
[not found] ` <1344266253-14050-1-git-send-email-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-08-06 15:35 ` [PATCH 1/1 v2] " Lee Jones
2012-08-07 9:47 ` Linus Walleij
2012-08-07 11:41 ` Lee Jones [this message]
2012-08-07 15:31 ` Lee Jones
[not found] ` <20120807153112.GF10719-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-08-08 12:38 ` Linus Walleij
[not found] ` <CACRpkdZj2LqFF_i6f3M2uzUkhG6og5n2cTzUgqRZA1_NmhWBNA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-08-08 13:09 ` Lee Jones
2012-08-08 13:11 ` [PATCH 1/1 v4] " Lee Jones
[not found] ` <20120808131158.GD8227-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-08-17 15:02 ` Linus Walleij
[not found] ` <CACRpkdb+6S5yYvVjrr2f+wubE43dzD3i=OVfWtM_U+HW_XZX1A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-08-17 19:05 ` Wolfram Sang
2012-08-18 8:01 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120807114113.GA5684@gmail.com \
--to=lee.jones@linaro.org \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=arnd@arndb.de \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).