From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 1/1 v2] i2c: Add default configuration into the Nomadik I2C driver. Date: Tue, 7 Aug 2012 12:41:15 +0100 Message-ID: <20120807114113.GA5684@gmail.com> References: <1344266253-14050-1-git-send-email-lee.jones@linaro.org> <20120806153503.GH10524@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Linus Walleij Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, linus.walleij@stericsson.com, arnd@arndb.de, w.sang@pengutronix.de, linux-i2c@vger.kernel.org List-Id: linux-i2c@vger.kernel.org > > diff --git a/drivers/gpu/mali/mali400ko/driver/src/devicedrv/mali/a= rch b/drivers/gpu/mali/mali400ko/driver/src/devicedrv/mali/arch > > new file mode 120000 > > index 0000000..427334b > > --- /dev/null > > +++ b/drivers/gpu/mali/mali400ko/driver/src/devicedrv/mali/arch > > @@ -0,0 +1 @@ >=20 > NACK, what is this stuff? It's even out-of-tree code. Whoa, no idea! Good spot though, I missed this completely. > Please be careful with git add -A, I prefer to use git add > I suspect that may be why this happened... I don't use `git add -A`, ever. If I'm adding files, I usually use=20 `git commit -s -- `, or `git commit -a` if I'm sure I require all the necessary changes. I guess I could have accidentally collected=20 it using `git add -i` whist fixing it up, or a similar misdemeanor. > Please fix it up and send a v3. Of course. --=20 Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog