From: Wolfram Sang <w.sang@pengutronix.de>
To: Lee Jones <lee.jones@linaro.org>
Cc: linus.walleij@stericsson.com, arnd@arndb.de,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
STEricsson_nomadik_linux@list.st.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1 v4] i2c: Add default configuration into the Nomadik I2C driver.
Date: Sat, 18 Aug 2012 10:01:10 +0200 [thread overview]
Message-ID: <20120818080110.GC24639@pengutronix.de> (raw)
In-Reply-To: <20120808131158.GD8227@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1219 bytes --]
On Wed, Aug 08, 2012 at 02:11:59PM +0100, Lee Jones wrote:
> From: Lee Jones <lee.jones@linaro.org>
> Date: Tue, 7 Aug 2012 12:27:24 +0100
> Subject: [PATCH 1/1 v4] i2c/nomadik: Add default configuration into the Nomadik I2C driver
Actually, unlike Linus said, I prefer "i2c: nomadik:"; minor nit,
though.
>
> At this moment in time there is only one known configuration for the
> Nomadik I2C driver. By not holding that configuration in the driver
> adds some unnecessary overhead in platform code. The configuration
> as already been removed from platform code, this patch checks for any
^^ has ( I fixed it )
> over-riding configurations. If there aren't any, the default is used.
>
> Cc: linux-i2c@vger.kernel.org
> Acked-by: srinidhi kasagar <srinidhi.kasagar@stericsson.com>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Applied to -current, thanks! I added a note from Linus that it is needed
because of boot regressions. That is also useful in commit messages.
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2012-08-18 8:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 15:17 [PATCH 1/1] i2c: Add default configuration into the Nomadik I2C driver Lee Jones
[not found] ` <1344266253-14050-1-git-send-email-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-08-06 15:35 ` [PATCH 1/1 v2] " Lee Jones
2012-08-07 9:47 ` Linus Walleij
2012-08-07 11:41 ` Lee Jones
2012-08-07 15:31 ` Lee Jones
[not found] ` <20120807153112.GF10719-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-08-08 12:38 ` Linus Walleij
[not found] ` <CACRpkdZj2LqFF_i6f3M2uzUkhG6og5n2cTzUgqRZA1_NmhWBNA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-08-08 13:09 ` Lee Jones
2012-08-08 13:11 ` [PATCH 1/1 v4] " Lee Jones
[not found] ` <20120808131158.GD8227-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-08-17 15:02 ` Linus Walleij
[not found] ` <CACRpkdb+6S5yYvVjrr2f+wubE43dzD3i=OVfWtM_U+HW_XZX1A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-08-17 19:05 ` Wolfram Sang
2012-08-18 8:01 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120818080110.GC24639@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=arnd@arndb.de \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).