From: Wolfram Sang <w.sang@pengutronix.de>
To: Kevin Hilman <khilman@ti.com>
Cc: linux-i2c@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Shubhrajyoti D <shubhrajyoti@ti.com>
Subject: Re: [PATCH] I2C: OMAP: xfer: fix runtime PM get/put balance on error
Date: Sat, 18 Aug 2012 10:13:00 +0200 [thread overview]
Message-ID: <20120818081300.GE24639@pengutronix.de> (raw)
In-Reply-To: <87wr1b35qb.fsf@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]
On Mon, Aug 06, 2012 at 05:28:44PM -0700, Kevin Hilman wrote:
> Hi Wolfram,
>
> Kevin Hilman <khilman@ti.com> writes:
>
> > In omap_i2c_xfer(), ensure pm_runtime_put() is called, even on
> > failure.
> >
> > Without this, after a failed xfer, the runtime PM usecount will have
> > been incremented, but not decremented causing the usecount to never
> > reach zero after a failure. This keeps the device always runtime PM
> > enabled which keeps the enclosing power domain active, and prevents
> > full-chip retention/off from happening during idle.
> >
> > Cc: Shubhrajyoti D <shubhrajyoti@ti.com>
> > Signed-off-by: Kevin Hilman <khilman@ti.com>
> > ---
> > This patch applies to current i2c-embedded/for-next branch
>
> This one is needed for v3.6. Can you queue this up as a fix for
> v3.6-rc?
Done, applied to -current, thanks!
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2012-08-18 8:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 1:45 [PATCH] I2C: OMAP: xfer: fix runtime PM get/put balance on error Kevin Hilman
[not found] ` <1340761532-27231-1-git-send-email-khilman-l0cyMroinI0@public.gmane.org>
2012-06-27 6:11 ` Shubhrajyoti Datta
[not found] ` <CAM=Q2cuLCT2VzcUgrpyRWiX61t1F+iWchO9iLC=Ka9MFVm4_bQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-06-28 21:55 ` Kevin Hilman
[not found] ` <87lij7nltv.fsf-l0cyMroinI0@public.gmane.org>
2012-06-29 5:47 ` Shubhrajyoti
2012-08-07 0:28 ` Kevin Hilman
2012-08-18 8:13 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120818081300.GE24639@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=shubhrajyoti@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).