From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH] I2C: OMAP: xfer: fix runtime PM get/put balance on error Date: Sat, 18 Aug 2012 10:13:00 +0200 Message-ID: <20120818081300.GE24639@pengutronix.de> References: <1340761532-27231-1-git-send-email-khilman@ti.com> <87wr1b35qb.fsf@ti.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="KuLpqunXa7jZSBt+" Return-path: Content-Disposition: inline In-Reply-To: <87wr1b35qb.fsf@ti.com> Sender: linux-omap-owner@vger.kernel.org To: Kevin Hilman Cc: linux-i2c@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Shubhrajyoti D List-Id: linux-i2c@vger.kernel.org --KuLpqunXa7jZSBt+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 06, 2012 at 05:28:44PM -0700, Kevin Hilman wrote: > Hi Wolfram, >=20 > Kevin Hilman writes: >=20 > > In omap_i2c_xfer(), ensure pm_runtime_put() is called, even on > > failure. > > > > Without this, after a failed xfer, the runtime PM usecount will have > > been incremented, but not decremented causing the usecount to never > > reach zero after a failure. This keeps the device always runtime PM > > enabled which keeps the enclosing power domain active, and prevents > > full-chip retention/off from happening during idle. > > > > Cc: Shubhrajyoti D > > Signed-off-by: Kevin Hilman > > --- > > This patch applies to current i2c-embedded/for-next branch >=20 > This one is needed for v3.6. Can you queue this up as a fix for > v3.6-rc? Done, applied to -current, thanks! --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --KuLpqunXa7jZSBt+ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlAvTowACgkQD27XaX1/VRvHagCdFt7xlJ91Z97p3QZp8wmDm4zD /T4AoLGEWoPGu4bl86uqWKkFEW2L8uTf =IhI+ -----END PGP SIGNATURE----- --KuLpqunXa7jZSBt+--