From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 3/3] i2c: nomadik: Add Device Tree support to the Nomadik I2C driver Date: Wed, 5 Sep 2012 07:41:07 +0100 Message-ID: <20120905064106.GA4233@gmail.com> References: <20120831122323.GC5962@gmail.com> <5044C82E.5060207@gmail.com> <20120903152012.GH31163@gmail.com> <201209041428.21409.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Linus Walleij Cc: Arnd Bergmann , Alessandro Rubini , Russell King - ARM Linux , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , Stephen Warren , linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Wolfram Sang , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, STEricsson_nomadik_linux-nkJGhpqTU55BDgjK7y7TUQ@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: linux-i2c@vger.kernel.org On Tue, Sep 04, 2012 at 07:27:10PM +0200, Linus Walleij wrote: > On Tue, Sep 4, 2012 at 4:28 PM, Arnd Bergmann wrote: >=20 > > In this particular case, we don't have a single board file providin= g a > > struct nmk_i2c_controller definition for platform data, so the best= way > > to handle this IMHO is to remove the header file with the platform > > data definition, and just encode the defaults in the driver. >=20 > Alessandro Rubini is actively working on bridging this (and > other amba_device primecells) to PCI, that is the reason why it > was recently converted to an amba_device. How is he then supposed to > get the proper parameters into the driver? Note that the PCI ID > is no help at all since the parameters depend on what is connected > to the I2C bus, not on what it itself is connected to. Isn't platform= data > used in such cases? So why can't Alessandro continue to use Platform Data in the normal way= ? --=20 Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog