From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Linux I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: Michael Lawnick <ml.lawnick-Mmb7MZpHnFY@public.gmane.org>
Subject: Re: [PATCH v2] i2c-core: Fix for lockdep validator
Date: Sat, 8 Sep 2012 09:31:05 +0200 [thread overview]
Message-ID: <20120908093105.2447620d@endymion.delvare> (raw)
In-Reply-To: <20120907225844.2c935ac9-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
On Fri, 7 Sep 2012 22:58:44 +0200, Jean Delvare wrote:
> If kernel is compiled with CONFIG_PROVE_LOCKING the
> validator raises an error when a multiplexer is removed
> via sysfs and sub-clients are connected to it. This is a
> false positive.
> Documentation/lockdep-design.txt recommends to handle this
> via calls to mutex_lock_nested().
>
> Based on an earlier fix from Michael Lawnick.
>
> Note that the extra code resolves to nothing unless
> CONFIG_DEBUG_LOCK_ALLOC=y.
... which in turn causes a compiler warning if CONFIG_DEBUG_LOCK_ALLOC
isn't set.
drivers/i2c/i2c-core.c:639:21: warning: ‘i2c_adapter_depth’ defined but not used [-Wunused-function]
Not sure how I missed that yesterday. I'll make the function inline,
that should fix it, and that's what gcc ends up doing anyway.
--
Jean Delvare
prev parent reply other threads:[~2012-09-08 7:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 20:58 [PATCH v2] i2c-core: Fix for lockdep validator Jean Delvare
[not found] ` <20120907225844.2c935ac9-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-09-08 7:31 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120908093105.2447620d@endymion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ml.lawnick-Mmb7MZpHnFY@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).