linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH] i2c: mxs: correctly setup speed for non devicetree
Date: Sun, 16 Sep 2012 10:15:25 +0200	[thread overview]
Message-ID: <20120916081525.GA4367@pengutronix.de> (raw)
In-Reply-To: <201209152009.44320.marex-ynQEQJNshbs@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 532 bytes --]


> > Commit cd4f2d4 (i2c: mxs: Set I2C timing registers for mxs-i2c) only
> > covered the case for devicetree and made platform_data based boards
> > bail out with -EINVAL. Correctly support the latter one, too.
> 
> MXS is now DT only, so this patch is pointless.

This is not true for 3.5.

> Rather make it depend on CONFIG_OF 

I wanted to avoid ifdeffery.

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  parent reply	other threads:[~2012-09-16  8:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-08 15:38 [PATCH] i2c: mxs: correctly setup speed for non devicetree Wolfram Sang
     [not found] ` <1347118732-4896-1-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-09-15 18:09   ` Marek Vasut
     [not found]     ` <201209152009.44320.marex-ynQEQJNshbs@public.gmane.org>
2012-09-16  8:15       ` Wolfram Sang [this message]
     [not found]         ` <20120916081525.GA4367-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-09-16 10:05           ` Marek Vasut
     [not found]             ` <201209161205.42575.marex-ynQEQJNshbs@public.gmane.org>
2012-09-16 10:24               ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120916081525.GA4367@pengutronix.de \
    --to=w.sang-bicnvbalz9megne8c9+irq@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=marex-ynQEQJNshbs@public.gmane.org \
    --cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).