From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Jim Cromie <jim.cromie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org
Subject: Re: [PATCH] i2c/scx200_*: replace printks with pr_<level>s, rev2 checkpatch clean
Date: Sat, 22 Sep 2012 16:14:08 +0200 [thread overview]
Message-ID: <20120922161408.520ea802@endymion.delvare> (raw)
In-Reply-To: <1347768201-11910-1-git-send-email-jim.cromie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Hi Jim,
On Sat, 15 Sep 2012 22:03:21 -0600, Jim Cromie wrote:
> Replace printks with pr_<level>s, add pr_fmt()s to replace NAMEs
>
> Signed-off-by: Jim Cromie <jim.cromie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> drivers/i2c/busses/scx200_acb.c | 22 +++++++++++-----------
> drivers/i2c/busses/scx200_i2c.c | 13 +++++++------
> 2 files changed, 18 insertions(+), 17 deletions(-)
This looks good, thanks for the cleanup. But you can go one step
further and remove the NAME defines, as they are no longer used
anywhere in the drivers.
I did that for you, no need to resend. Patch applied.
--
Jean Delvare
prev parent reply other threads:[~2012-09-22 14:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-16 4:03 [PATCH] i2c/scx200_*: replace printks with pr_<level>s, rev2 checkpatch clean Jim Cromie
[not found] ` <1347768201-11910-1-git-send-email-jim.cromie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-09-22 14:14 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120922161408.520ea802@endymion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=jim.cromie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).