From: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Linus Walleij <linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
Cc: Ben Dooks <ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Anmar Oueja <anmar.oueja-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Patrice Chotard
<patrice.chotard-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v2] i2c: nomadik: adopt pinctrl support
Date: Sat, 6 Oct 2012 15:30:06 +0200 [thread overview]
Message-ID: <20121006133006.GA25123@pengutronix.de> (raw)
In-Reply-To: <1348837151-20820-1-git-send-email-linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 698 bytes --]
Hi,
> + ret = clk_prepare(dev->clk);
> + if (ret) {
> + dev_err(&adev->dev, "can't prepare clock\n");
> + goto err_prep_clk;
> + }
> +
> adap = &dev->adap;
> adap->dev.parent = &adev->dev;
> adap->owner = THIS_MODULE;
> @@ -994,6 +1092,8 @@ static int nmk_i2c_probe(struct amba_device *adev, const struct amba_id *id)
> return 0;
>
> err_add_adap:
> + clk_unprepare(dev->clk);
> + err_prep_clk:
This is unrelated, right? And it is also unneeded because of Ulf
Hansson's patch?
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-10-06 13:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 12:59 [PATCH v2] i2c: nomadik: adopt pinctrl support Linus Walleij
[not found] ` <1348837151-20820-1-git-send-email-linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
2012-10-06 13:30 ` Wolfram Sang [this message]
[not found] ` <20121006133006.GA25123-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-10-10 8:03 ` Linus Walleij
2012-10-10 9:16 ` Linus Walleij
[not found] ` <CACRpkdbdH6uLMt9oRTDEH3TBFppb2idtapHRKjoGtQ3cfvis2g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-10 9:27 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121006133006.GA25123@pengutronix.de \
--to=w.sang-bicnvbalz9megne8c9+irq@public.gmane.org \
--cc=anmar.oueja-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=patrice.chotard-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).