From: Jean Delvare <khali@linux-fr.org>
To: "Stéphane Chatty" <chatty@enac.fr>
Cc: "benjamin.tissoires" <benjamin.tissoires@gmail.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Jiri Kosina" <jkosina@suse.cz>,
"Fabien André" <fabien.andre@gmail.com>,
劉嘉駿 <scott.liu@emc.com.tw>, "Ben Dooks" <ben-linux@fluff.org>,
"Wolfram Sang" <w.sang@pengutronix.de>,
linux-i2c@vger.kernel.org,
"USB list" <linux-input@vger.kernel.org>,
linux-kernel@vger.kernel.org,
"Marcel Holtmann" <marcel@holtmann.org>
Subject: Re: [PATCH v1] i2c-hid: introduce HID over i2c specification implementation
Date: Sat, 6 Oct 2012 23:11:11 +0200 [thread overview]
Message-ID: <20121006231111.6350c014@endymion.delvare> (raw)
In-Reply-To: <6F756B9E-DC87-4EF6-BB09-8A69A5F8C999@enac.fr>
On Sat, 6 Oct 2012 22:30:00 +0200, Stéphane Chatty wrote:
> Le 6 oct. 2012 à 22:04, Jean Delvare a écrit :
> > Looks like the wrong place for this driver. HID-over-USB support lives
> > under drivers/hid, so your driver should go there as well. Not only
> > this will be more consistent, but it also makes more sense: your driver
> > is a user, not an implementer, of the I2C layer, so it doesn't belong
> > to drivers/i2c.
>
> This is a question I asked a few months back, but apparently not all points of views had been expressed at the time. Currently, HID-over-USB lives in drivers/hid, but HID-over-BT lives in drivers/bluetooth. When I asked, Jiri explained that he maintained HID-over-USB and Marcel maintained HID-over-BT, which explained the choices made. Let's try to summarize what we know now:
>
> The question is what drives the choice of where to put HID-over-XXX, among the following
> 1- who the maintainer is. Here, Benjamin will probably maintain this so it does not help.
> 2- dependencies. HID-over-XXX depends on HID as much as it depends on XXX, so it does not help.
> 3- data flow. Indeed, HID is a client of HID-over-XXX which is a client of XXX. Are there other parts of the kernel where this drives the choice of where YYY-over-XXX lives?
>
> Jiri, Marcel, Greg, others, any opinions?
My vote is a clear 3. It took me a few years to kick all users (as
opposed to implementers) of i2c from drivers/i2c and finding them a
proper home, I'm not going to accept new intruders. Grouping drivers
according to what they implement makes it a lot easier to share code
and ideas between related drivers. If you want to convince yourself,
just imagine the mess it would be if all drivers for PCI devices lived
under drivers/pci.
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-10-06 21:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 13:41 [PATCH v1] i2c-hid: introduce HID over i2c specification implementation benjamin.tissoires
[not found] ` < 20121006220421.47f5fd56@endymion.delvare>
[not found] ` <1347630103-4105-1-git-send-email-benjamin.tissoires-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-03 3:08 ` Jian-Jhong Ding
2012-10-03 15:13 ` Benjamin Tissoires
2012-10-03 6:05 ` Shubhrajyoti Datta
[not found] ` <CAM=Q2cuVa9yLY7-nRz26OYktgM3i+dOfDa8vVznwMVrs9pH5sg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-03 15:33 ` Benjamin Tissoires
2012-10-03 16:14 ` Shubhrajyoti Datta
2012-10-03 16:43 ` Dmitry Torokhov
[not found] ` <20121003164306.GA18529-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2012-10-04 9:16 ` Benjamin Tissoires
[not found] ` <CAN+gG=H1BWmA_VW_RrhYWVU7qXrqbzhGCkkY0_41muL=XqJbjA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-04 9:48 ` Jiri Kosina
2012-10-06 19:54 ` Jean Delvare
2012-10-06 20:04 ` Jean Delvare
[not found] ` <20121006220421.47f5fd56-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-10-06 20:30 ` Stéphane Chatty
2012-10-06 21:11 ` Jean Delvare [this message]
[not found] ` <alpine.LNX.2.00.1210 062314110.27782@pobox.suse.cz>
2012-10-06 21:18 ` Jiri Kosina
2012-10-06 21:28 ` Jiri Kosina
[not found] ` <alpine.LNX.2.00.1210062326150.27782-ztGlSCb7Y1iN3ZZ/Hiejyg@public.gmane.org>
2012-10-06 21:39 ` Stéphane Chatty
[not found] ` <914C6C58-5A3B-4F7D-94BE-EF6868ED5D9D-rXV5z7KbLFk@public.gmane.org>
2012-10-07 16:07 ` Benjamin Tissoires
[not found] ` <CAN+gG=FOnFDn4BdEQUt0dbQRj-6PrhRzSOqM620xSM3DeTXt_Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-07 16:20 ` Stéphane Chatty
2012-10-08 14:42 ` Jiri Kosina
2012-10-06 21:27 ` Stéphane Chatty
2012-10-07 7:16 ` Jean Delvare
2012-10-07 16:00 ` Benjamin Tissoires
2012-10-07 14:28 ` Jean Delvare
[not found] ` <20121007162838.01f36b7c-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-10-07 16:57 ` Benjamin Tissoires
[not found] ` <CAN+gG=E3nmXZ9RL3wN2tvKqSOu5hWYLXLf+Z=ag7VvZGJfhQ-w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-07 19:03 ` Jean Delvare
[not found] ` <20121007210359.29f40ecf-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-10-15 20:42 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121006231111.6350c014@endymion.delvare \
--to=khali@linux-fr.org \
--cc=ben-linux@fluff.org \
--cc=benjamin.tissoires@gmail.com \
--cc=chatty@enac.fr \
--cc=dmitry.torokhov@gmail.com \
--cc=fabien.andre@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=scott.liu@emc.com.tw \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).