Re: [PATCH] char/tpm: Convert struct i2c_msg initialization to C99 format

[Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>]

On Tue, 9 Oct 2012 17:12:31 +0530, Shubhrajyoti D wrote:
> Convert the struct i2c_msg initialization to C99 format. This makes
> maintaining and editing the code simpler. Also helps once other fields
> like transferred are added in future.
> 
> Thanks to Julia Lawall <julia.lawall-L2FTfq7BK8M@public.gmane.org>  for automating the conversion
> 
> Signed-off-by: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
> ---
>  drivers/char/tpm/tpm_i2c_infineon.c |   21 ++++++++++++++++++---
>  1 files changed, 18 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/char/tpm/tpm_i2c_infineon.c b/drivers/char/tpm/tpm_i2c_infineon.c
> index 5a831ae..01b07c7 100644
> --- a/drivers/char/tpm/tpm_i2c_infineon.c
> +++ b/drivers/char/tpm/tpm_i2c_infineon.c
> @@ -90,8 +90,18 @@ static struct i2c_driver tpm_tis_i2c_driver;
>  static int iic_tpm_read(u8 addr, u8 *buffer, size_t len)
>  {
>  
> -	struct i2c_msg msg1 = { tpm_dev.client->addr, 0, 1, &addr };
> -	struct i2c_msg msg2 = { tpm_dev.client->addr, I2C_M_RD, len, buffer };
> +	struct i2c_msg msg1 = {
> +		.addr = tpm_dev.client->addr,
> +		.flags = 0,

As said before, you can omit zero fields.

> +		.len = 1,
> +		.buf = &addr
> +	};
> +	struct i2c_msg msg2 = {
> +		.addr = tpm_dev.client->addr,
> +		.flags = I2C_M_RD,
> +		.len = len,
> +		.buf = buffer
> +	};
>  
>  	int rc;
>  	int count;
> @@ -138,7 +148,12 @@ static int iic_tpm_write_generic(u8 addr, u8 *buffer, size_t len,
>  	int rc = -EIO;
>  	int count;
>  
> -	struct i2c_msg msg1 = { tpm_dev.client->addr, 0, len + 1, tpm_dev.buf };
> +	struct i2c_msg msg1 = {
> +			.addr = tpm_dev.client->addr,
> +			.flags = 0,
> +			.len = len + 1,
> +			.buf = tpm_dev.buf
> +	};
>  
>  	if (len > TPM_BUFSIZE)
>  		return -EINVAL;

Acked-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>

-- 
Jean Delvare