From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH] i2c: tegra: set irq name as device name Date: Sat, 13 Oct 2012 15:01:58 +0200 Message-ID: <20121013150158.2eb1ece2@endymion.delvare> References: <1350064172-32417-1-git-send-email-ldewangan@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1350064172-32417-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Laxman Dewangan Cc: w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org On Fri, 12 Oct 2012 23:19:32 +0530, Laxman Dewangan wrote: > When watching the irqs name of tegra i2c, all instances > irq name shows as tegra_i2c. > > Passing the device name properly to have the irq names with > instance like tegra-i2c.0, tegra-i2c.1 etc. > > Signed-off-by: Laxman Dewangan > --- > drivers/i2c/busses/i2c-tegra.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c > index f981ac4..dcea77b 100644 > --- a/drivers/i2c/busses/i2c-tegra.c > +++ b/drivers/i2c/busses/i2c-tegra.c > @@ -742,7 +742,7 @@ static int __devinit tegra_i2c_probe(struct platform_device *pdev) > } > > ret = devm_request_irq(&pdev->dev, i2c_dev->irq, > - tegra_i2c_isr, 0, pdev->name, i2c_dev); > + tegra_i2c_isr, 0, dev_name(&pdev->dev), i2c_dev); > if (ret) { > dev_err(&pdev->dev, "Failed to request irq %i\n", i2c_dev->irq); > return ret; Good idea. Acked-by: Jean Delvare -- Jean Delvare