From: Jean Delvare <khali@linux-fr.org>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org,
"Ben Dooks (embedded platforms)" <ben-linux@fluff.org>,
"Wolfram Sang (embedded platforms)" <w.sang@pengutronix.de>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH 08/16] i2c: Convert dev_printk(KERN_<LEVEL> to dev_<level>(
Date: Sun, 28 Oct 2012 12:45:10 +0100 [thread overview]
Message-ID: <20121028124510.76e23bd5@endymion.delvare> (raw)
In-Reply-To: <3e4988b083a8b5d03a458aabc18042cedb3dbd8a.1351411047.git.joe@perches.com>
Hi Joe,
On Sun, 28 Oct 2012 01:05:46 -0700, Joe Perches wrote:
> dev_<level> calls take less code than dev_printk(KERN_<LEVEL>
> and reducing object size is good.
> Coalesce formats for easier grep.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/i2c/busses/i2c-piix4.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
> index 8bbd6ec..f7216ed 100644
> --- a/drivers/i2c/busses/i2c-piix4.c
> +++ b/drivers/i2c/busses/i2c-piix4.c
> @@ -204,9 +204,8 @@ static int __devinit piix4_setup(struct pci_dev *PIIX4_dev,
> */
> pci_write_config_byte(PIIX4_dev, SMBHSTCFG,
> temp | 1);
> - dev_printk(KERN_NOTICE, &PIIX4_dev->dev,
> - "WARNING: SMBus interface has been "
> - "FORCEFULLY ENABLED!\n");
> + dev_notice(&PIIX4_dev->dev,
> + "WARNING: SMBus interface has been FORCEFULLY ENABLED!\n");
> } else {
> dev_err(&PIIX4_dev->dev,
> "Host SMBus controller not enabled!\n");
Applied, thanks.
--
Jean Delvare
next prev parent reply other threads:[~2012-10-28 11:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-28 8:05 [PATCH 00/16] treewide: Convert dev_printk(KERN_<LEVEL> to dev_<level>( Joe Perches
2012-10-28 8:05 ` [PATCH 08/16] i2c: " Joe Perches
2012-10-28 11:45 ` Jean Delvare [this message]
[not found] ` <cover.1351411047.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2012-10-28 10:54 ` [PATCH 00/16] treewide: " Sergei Shtylyov
[not found] ` <508D0ECA.8040008-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
2012-10-28 12:12 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121028124510.76e23bd5@endymion.delvare \
--to=khali@linux-fr.org \
--cc=ben-linux@fluff.org \
--cc=joe@perches.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).